831133 - Record only the basename

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=78ab105e4c80

For the symbolication server we only want the basename, since this is what is used to store the .sym files. Unfortunately we have to do this is Telemetry for now an the current profiler plugin needs the full file name on OS X.

Comment 1

[Vladan Djeric (:vladan)]

Comment on attachment 702638 [details] [diff] [review]
patch

> #ifdef MOZ_ENABLE_PROFILER_SPS
>   for (unsigned i = 0, n = rawModules.GetSize(); i != n; ++i) {
>     const SharedLibrary &info = rawModules.GetEntry(i);
>+    const std::string &name = info.GetName();
>+    size_t pos = name.rfind('/');

This works but how about #ifdef'ing XP_MACOSX around some of this logic and calling basename()?

>+    std::string basename;
>+    if (pos != std::string::npos)
>+      basename = name.substr(pos + 1);
>+    else
>+      basename = name;

Style rules say you need curlies for these

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0071573033

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8d0071573033