Make DOMWillOpenModalDialog a chrome-only event in Metro

RESOLVED FIXED

Status

Firefox for Metro
Components
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: fryn, Assigned: fryn)

Tracking

Trunk
All
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [completed-elm])

Attachments

(1 attachment, 1 obsolete attachment)

1.45 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 702686 [details] [diff] [review]
patch

Bug 611553 specifically for Metro, since we haven't merged elm to mozilla-central yet.

We'll need to wait for the patch in bug 611553 to get landed on mozilla-central and then for us to pull that onto elm before pushing the patch here.
Attachment #702686 - Flags: review?(mbrubeck)
(Assignee)

Comment 1

5 years ago
Created attachment 702688 [details] [diff] [review]
patch

Flipping the "cancelable" boolean to be consistent with nsAutoWindowStateHelper, nsPrompter, and every other case where DOMWillOpenModalDialog is fired.
Attachment #702686 - Attachment is obsolete: true
Attachment #702686 - Flags: review?(mbrubeck)
Attachment #702688 - Flags: review?(mbrubeck)
Attachment #702688 - Flags: review?(mbrubeck) → review+
(Assignee)

Updated

5 years ago
OS: Windows 8 → Windows 8 Metro
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/elm/rev/5be0af14fd5e
Whiteboard: [completed-elm]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.