Closed Bug 831166 Opened 7 years ago Closed 7 years ago

Make DOMWillOpenModalDialog a chrome-only event in Metro

Categories

(Firefox for Metro Graveyard :: Components, defect)

All
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fryn, Assigned: fryn)

References

Details

(Whiteboard: [completed-elm])

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Bug 611553 specifically for Metro, since we haven't merged elm to mozilla-central yet.

We'll need to wait for the patch in bug 611553 to get landed on mozilla-central and then for us to pull that onto elm before pushing the patch here.
Attachment #702686 - Flags: review?(mbrubeck)
Attached patch patchSplinter Review
Flipping the "cancelable" boolean to be consistent with nsAutoWindowStateHelper, nsPrompter, and every other case where DOMWillOpenModalDialog is fired.
Attachment #702686 - Attachment is obsolete: true
Attachment #702686 - Flags: review?(mbrubeck)
Attachment #702688 - Flags: review?(mbrubeck)
Attachment #702688 - Flags: review?(mbrubeck) → review+
OS: Windows 8 → Windows 8 Metro
https://hg.mozilla.org/projects/elm/rev/5be0af14fd5e
Whiteboard: [completed-elm]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.