about:plugins lists blocklisted and user-disabled plugins

VERIFIED FIXED in Firefox 21

Status

()

Core
Plug-ins
P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mario garbi, Assigned: cpeterson)

Tracking

({regression})

21 Branch
mozilla21
regression
Points:
---
Dependency tree / graph
Bug Flags:
in-qa-testsuite +

Firefox Tracking Flags

(firefox20 unaffected, firefox21+ fixed)

Details

(Whiteboard: [mozmill], URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Because of bug 757726 (http://hg.mozilla.org/mozilla-central/rev/42b22f0ab58c ) about:plugins doesn't update the lists of disabled plugins from AddonsManager anymore.

 Manually reproduced:
 1.Open Addons Manager
 2.Disable a plugin
 3.Open about:plugins
 
  Results:
 -plugin did not disappeared from about:plugins when disabled in Addons Manager as it should have.
Reason here is that we no longer filter by enabled plugins:
http://hg.mozilla.org/mozilla-central/file/42b22f0ab58c/toolkit/content/plugins.html#l60

This regression has been found by Mozmill.
tracking-firefox21: --- → ?
Hardware: x86 → All
Summary: about:plugins doesn't update the lists of disabled plugins from AddonsManager anymore → about:plugins doesn't hide disabled plugins anymore
Whiteboard: [mozmill]
I'm actually happy with this change and think we should keep it. It's useful to be able to see the full version information for plugins even if they are disabled in the addons manager. The only think I would change is that we should show the enabled/disabled state in about:plugins. So I'm going to morph this bug.
Summary: about:plugins doesn't hide disabled plugins anymore → about:plugins should show the enabled/disabled state of plugins
Assignee: nobody → cpeterson
Priority: -- → P2
This change causes a permanent test failure in our testsuite. It would be nice if we can get this fixed sooner than later. What does P2 mean? I just wonder if we should disable the test for the time being.
P2 means that somebody is working on it but it doesn't stop all other activity.
(Assignee)

Comment 5

4 years ago
Created attachment 702932 [details] [diff] [review]
skip-inactive-plugins.patch

Here is a quick fix for the about:plugins regression. It skips "inactive" plugins, which includes both blocklisted and user-disabled.

I assume the previous about:plugins implementation using navigator.plugins skipped blocklisted plugins, but I don't have any blocklisted plugins installed that I can test with.

I agree with bsmedberg that about:plugins should show all plugins plus their enabled/disabled/blocklisted status, but I think fixing this about:plugins regression in the meantime makes sense.
Attachment #702932 - Flags: review?(joshmoz)
Attachment #702932 - Flags: feedback?(benjamin)

Updated

4 years ago
status-firefox20: --- → unaffected
status-firefox21: --- → affected
tracking-firefox21: ? → +
Comment on attachment 702932 [details] [diff] [review]
skip-inactive-plugins.patch

Yeah, if this is easier we can do it for now. Can you file the bug I wished we had?
Attachment #702932 - Flags: review?(joshmoz)
Attachment #702932 - Flags: review+
Attachment #702932 - Flags: feedback?(benjamin)
Attachment #702932 - Flags: feedback+
(Assignee)

Comment 7

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f28e36cd272
Status: NEW → ASSIGNED
status-firefox21: affected → fixed
Summary: about:plugins should show the enabled/disabled state of plugins → about:plugins lists blocklisted and user-disabled plugins
Target Milestone: --- → mozilla21
(Assignee)

Updated

4 years ago
Blocks: 831533
(Assignee)

Comment 8

4 years ago
I filed bug 831533 to track the plugin status bug.
(Assignee)

Updated

4 years ago
Duplicate of this bug: 830262
Chris, thank you for fixing it that quickly!
Flags: in-qa-testsuite+
https://hg.mozilla.org/mozilla-central/rev/2f28e36cd272
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
That looks good in todays nightly build. Marking as verified fixed.
Status: RESOLVED → VERIFIED

Comment 13

4 years ago
Verified fixed on Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0
Verified fixed on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0


On Windows with Firefox 21 Beta 2(Build ID:20130408165307) I found an issue:

STR:
1.Open Addons Manager
 2.Disable a plugin
 3.Open about:plugins
 4.Go back to addons manager and Enable the same plugin
 5.Refresh about:plugins page

Actual result: 
Step 3 the plugin is disabled.
Step 5 the plugin is still disabled.

Notes: If I refresh the add-ons manager page at step 4, the previous action is not remembered.
 
Should I fill up a new bug?
Mitza, please check in FF22 first; I think we probably fixed this in bug 830267. If you can still reproduce it there, then yes, file a bug.

Comment 15

4 years ago
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20130412 Firefox/22.0

This is fixed on FF22 (Build ID:20130412004014), so I won't file a new bug.

Comment 16

4 years ago
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0

This issue is still reproducible on FF21 Beta5 (Build ID:20130425162858).
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0 
Build ID : 20130425162858

On FF21 Beta 5 the plugin is correctly shown in about:plugins with the state "Disabled"
As for the Comment 14 after the Step 5 the plugin is enabled.
You need to log in before you can comment on or make changes to this bug.