83119 - getComputedStyle() not supported for 'visibility'

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P2)

Description

[Henri Sivonen (:hsivonen)]

getComputedStyle(node, "").getPropertyValue("visibility") returns an empty string.

Steps to reproduce:
1) Load the test case.

Actual results:
The comparison of visibility and an empty string evaluates to true.

Expected results:
Expected a string reflecting the actual property to be retuned.

This bug blocks a complete implementation of bug 31961. (A partial implementation that just ignores visibility 
is possible, however.)

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Test case comparing visibility with an empty string

Comment 2

[Johnny Stenback (:jst)]

Harish, this would be a 5 or so line fix, right? Could you please look into this
for mozilla0.9.2 (setting milestone for you).

Comment 3

[harishd]

Attachment: patch v1.1

Comment 4

[Johnny Stenback (:jst)]

Does this patch still apply after hyatt's style code changes? If so, fix the
indentation at:

+    const nsCString& visibility=
+      nsCSSProps::SearchKeywordTable(display->mVisible,
+
                                 nsCSSProps::kVisibilityKTable);
                                      ^^^

and:

+  return val->QueryInterface(NS_GET_IID(nsIDOMCSSPrimitiveValue),
+
                           (void **)&aValue);
                              ^^^^^

and you'll have sr=jst

Comment 5

[harishd]

moving to 0.9.3

Comment 6

[harishd]

Attachment: patch v1.2

Comment 7

[Johnny Stenback (:jst)]

sr=jst

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

r=heikki

Comment 9

[harishd]

Moving to more realistic target - m0.9.4!

Comment 10

[harishd]

Fix landed on 08/07/01. Marking FIXED.