831198 - scrollbox calls to mozCancelAnimationFrame never stop mozRequestAnimationFrame

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[tabmix.onemen]

scrollbox.xml calls to stop animation in _scrollAnim.stop and _arrowScrollAnim.stop calls mozCancelAnimationFrame with the wrong requestHandle.

In both cases this.requestHandle is only saved once on start, it should also be save after each sample, so we can call mozCancelAnimationFrame with the latest requestHandle

Comment 1

[Boris Zbarsky [:bzbarsky]]

Oh, nice catch!

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Make _arrowScrollAnim.stop() and _scrollAnim.stop() actually cancel the pending requestAnimationFrame callback.

Comment 3

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/697dc09bdc2a

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/697dc09bdc2a