Closed Bug 831198 Opened 8 years ago Closed 8 years ago

scrollbox calls to mozCancelAnimationFrame never stop mozRequestAnimationFrame

Categories

(Toolkit :: XUL Widgets, defect)

Product:
Toolkit
Component:
XUL Widgets
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: tabmix.onemen, Assigned: bzbarsky)

Details

Attachments

(1 file)

Make _arrowScrollAnim.stop() and _scrollAnim.stop() actually cancel the pending requestAnimationFrame callback.
1.81 KB, patch
dao
: review+
Details | Diff | Splinter Review 
scrollbox.xml calls to stop animation in _scrollAnim.stop and _arrowScrollAnim.stop calls mozCancelAnimationFrame with the wrong requestHandle.

In both cases this.requestHandle is only saved once on start, it should also be save after each sample, so we can call mozCancelAnimationFrame with the latest requestHandle
Component: DOM → XUL Widgets
Product: Core → Toolkit
Oh, nice catch!
Assignee: nobody → bzbarsky
Whiteboard: [need review]
Attachment #702864 - Flags: review?(dao) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/697dc09bdc2a
Whiteboard: [need review]
Target Milestone: --- → mozilla21
https://hg.mozilla.org/mozilla-central/rev/697dc09bdc2a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.