831207 - Add PDF test files to testcase-data repository for PDF Viewer testing

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Infrastructure, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

We need test files to use in the automated tests for PDF Viewer.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, those test files should be used in MozTrap testcases. The Mozmill tests need to have those local as best as possible.

Comment 2

[Mihaela Velimiroviciu (:mihaelav)]

I gathered some test pdfs, but the patch is to large and cannot be uploaded to bugzilla. I will work on creating some smallesr test documents.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That would be appreciated Mihaela! Having testable PDF files which let us focus on the actual feature to test, are a good thing also for the automation. Thanks!

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Also it might be a copyright thing we have to take care of when attaching others PDF files.

Comment 5

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: test files for PDF Viewer

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 703280 [details] [diff] [review]
test files for PDF Viewer

Review of attachment 703280 [details] [diff] [review]:
-----------------------------------------------------------------

In general two things. Please try to reduce the size of the PDF files. Especially the file test589.pdf is too large. I strongly believe we can make this a lot smaller. Further please use readable file names for those testcases, so that someone knows for what they can be used for. Which tests do all of those PDFs cover?

Comment 7

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: test files for PDF Viewer v2

I created some new PDFs to be more specific for some tests, reduced the size of some files and renamed the files so that it's easier to know what test(s) they can be used for (except test.pdf, which can be used for the majority of tests). These files should cover all tests from Moztrap.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 703920 [details] [diff] [review]
test files for PDF Viewer v2

Review of attachment 703920 [details] [diff] [review]:
-----------------------------------------------------------------

I have some more questions and issue we should solve:

1) So what's special in test.pdf you need for testing? This file is still large and if possible we should reduce it. Could we take something with low resolution graphics or lesser images at all?

2) form.pdf is not working for me. I do not see the form fields in Aurora on OS X.

3) Why is the unicode PDF called 'nonUnicode'? We show unicode characters here.

::: firefox/pdf/embeddedPDFsTestPage.html
@@ +8,5 @@
> +  <object data="test.pdf" type="application/pdf" width="300" height="200"></object>
> +</div>
> +<div>
> +  <p> PDF embedded using the EMBED tag</p>
> +  <embed src="test.pdf" type="application/pdf" width="300" height="200"/>

Embedding the PDF via the embed tag doesn't work for me with Aurora on Mac. Is that a bug?

Comment 9

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: test files for PDF Viewer v3

(In reply to Henrik Skupin (:whimboo) from comment #8)
> Comment on attachment 703920 [details] [diff] [review]
> test files for PDF Viewer v2
> 
> Review of attachment 703920 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I have some more questions and issue we should solve:
> 
> 1) So what's special in test.pdf you need for testing? This file is still
> large and if possible we should reduce it. Could we take something with low
> resolution graphics or lesser images at all?

The test.pd should contain images and text in different formats. I created a smaller one.

> 
> 2) form.pdf is not working for me. I do not see the form fields in Aurora on
> OS X.

That's because PDF Viewer doesn't correctly handle the pdfs with forms. I also created other doc to make more visible where the form fields are

> 
> 3) Why is the unicode PDF called 'nonUnicode'? We show unicode characters
> here.

Actually, it should be non-ASCII. Renamed the file.

> 
> ::: firefox/pdf/embeddedPDFsTestPage.html
> @@ +8,5 @@
> > +  <object data="test.pdf" type="application/pdf" width="300" height="200"></object>
> > +</div>
> > +<div>
> > +  <p> PDF embedded using the EMBED tag</p>
> > +  <embed src="test.pdf" type="application/pdf" width="300" height="200"/>
> 
> Embedding the PDF via the embed tag doesn't work for me with Aurora on Mac.
> Is that a bug?

Yes, bug #738967.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 706369 [details] [diff] [review]
test files for PDF Viewer v3

Review of attachment 706369 [details] [diff] [review]:
-----------------------------------------------------------------

Those PDF files looks quite good now. Thanks for updating those. But there is one more thing we should fix before we can land this patch.

::: firefox/pdf/embeddedPDFsTestPage.html
@@ +8,5 @@
> +  <object data="test.pdf" type="application/pdf" width="300" height="200"></object>
> +</div>
> +<div>
> +  <p> PDF embedded using the EMBED tag</p>
> +  <embed src="test.pdf" type="application/pdf" width="300" height="200"/>

As long as embed doesn't work we should comment it out here and add a comment with the bug id in the form:

// Bug XYZ - Embed doesn't work yet

This will make sure that we are not getting flooded with failing reports for your embedding caseconductor testcase.

Comment 11

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: test files for PDF Viewer v4

(In reply to Henrik Skupin (:whimboo) from comment #10)
> As long as embed doesn't work we should comment it out here and add a
> comment with the bug id in the form:
> 
> // Bug XYZ - Embed doesn't work yet

Updated embeddedPDFsTestPage.html file: "PDF embedded using the EMBED tag (Bug 738967 - pdf.js doesn't work for embedded PDFs)"

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 709728 [details] [diff] [review]
test files for PDF Viewer v4

Review of attachment 709728 [details] [diff] [review]:
-----------------------------------------------------------------

Mihaela, I have seen that you have removed the forms.pdf file now. I don't see a reason why we shouldn't get this included as long as it is not referenced in a test. Will you add this file back?

::: firefox/pdf/embeddedPDFsTestPage.html
@@ +7,5 @@
> +  <p> PDF embedded using the OBJECT tag</p>
> +  <object data="test.pdf" type="application/pdf" width="300" height="200"></object>
> +</div>
> +<div>
> +  <p> PDF embedded using the EMBED tag (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=738967">Bug 738967</a> - pdf.js doesn't work for embedded PDFs) </p> <embed src="test.pdf" type="application/pdf" width="300" height="200"/>

nit: please fix the indentation.

Comment 13

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: test files PDF Viewer v5

(In reply to Henrik Skupin (:whimboo) from comment #12)
> Mihaela, I have seen that you have removed the forms.pdf file now. I don't
> see a reason why we shouldn't get this included as long as it is not
> referenced in a test. Will you add this file back?

Ups, I don't know how I missed that, sorry. I added it back.
> 
> ::: firefox/pdf/embeddedPDFsTestPage.html
> @@ +7,5 @@
> > +  <p> PDF embedded using the OBJECT tag</p>
> > +  <object data="test.pdf" type="application/pdf" width="300" height="200"></object>
> > +</div>
> > +<div>
> > +  <p> PDF embedded using the EMBED tag (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=738967">Bug 738967</a> - pdf.js doesn't work for embedded PDFs) </p> <embed src="test.pdf" type="application/pdf" width="300" height="200"/>
> 
> nit: please fix the indentation.

Fixed

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 710728 [details] [diff] [review]
test files PDF Viewer v5

Review of attachment 710728 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/testcase-data/rev/28541605a6ef