831217 - Align Contact Settings with the latest UX specifications

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

This bug is for Tracking all work to align Contact Settings with the latest UX specifications

Comment 1

[Dylan Oliver [:doliver]]

triage: blocking-

Please provide more detail (and possibly separate bugs) to clarify what changes are required.

Comment 2

[Jose Manuel Cantera]

Attachment: Pointer to GH PR 7653

Comment 3

[Jose Manuel Cantera]

(In reply to Dylan Oliver [:doliver] from comment #1)
> triage: blocking-
> 
> Please provide more detail (and possibly separate bugs) to clarify what
> changes are required.

The required changes are: 

Inform the user when the SIM card is not available for importing contacts (bug 820156)
Show a banner once SIM contacts are imported
Show a confirm BB when there is any kind of error 

All these changes are dependent on each other and that's why they have been fixed in only one bug.

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 703001 [details]
Pointer to GH PR 7653

r=me l10n-wise.

I'm not convinced that changing "Enable Facebook" to "Facebook" is a good decision.  If this is desired, please remove the importFb2 key from the properties file (unless it's used elsewhere?)

Comment 5

[Jose Manuel Cantera]

(In reply to Staś Małolepszy :stas from comment #4)
> Comment on attachment 703001 [details]
> Pointer to GH PR 7653
> 
> r=me l10n-wise.
> 
> I'm not convinced that changing "Enable Facebook" to "Facebook" is a good
> decision.  If this is desired, please remove the importFb2 key from the
> properties file (unless it's used elsewhere?)

Thanks Stas. I will double check that change with UX and proceed accordingly

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703001 [details]
Pointer to GH PR 7653

js looking good. Tried on the phone and working ok.

Great job!

Comment 7

[Jose Manuel Cantera]

(In reply to Staś Małolepszy :stas from comment #4)
> Comment on attachment 703001 [details]
> Pointer to GH PR 7653
> 
> r=me l10n-wise.
> 
> I'm not convinced that changing "Enable Facebook" to "Facebook" is a good
> decision.  If this is desired, please remove the importFb2 key from the
> properties file (unless it's used elsewhere?)

importFB2 has been removed

Comment 8

[Jose Manuel Cantera]

(In reply to Francisco Jordano [:arcturus] from comment #6)
> Comment on attachment 703001 [details]
> Pointer to GH PR 7653
> 
> js looking good. Tried on the phone and working ok.
> 
> Great job!

Francisco, can we land this?

Comment 9

[Jose Manuel Cantera]

Comment on attachment 703001 [details]
Pointer to GH PR 7653

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703001 [details]
Pointer to GH PR 7653

Important change to get in sync both experiences in FTU and Contacts.

Change requested by UX team, tested and not very risky.

a=me

Comment 11

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/ac025973c513881e162206d7d98512b26a452bcf