831241 - [Settings] "Create a password" does not fit as a title for the Lock screen

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

## Environment :
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/f2460bf17811
Gaia   7258384661345ded5a8813c34774ef8a0b56cc02
BuildID 20130114230201
Version 18.0
Otoro/Unagi

## Repro :
1. go to settings
2. go to Phone lock
3. turn on Passlock
4. look at the title

## Expected :
1. the title fits in the screen

## Actual :
1. the title doesn't fit.

## Note :

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

What should the title say, maybe 'Set passcode'?

Comment 2

[henriquea]

I can get this one. Not sure yet how to assign the ticket to myself here.

Comment 3

[Neeraj]

I have resolved this bus.Please assign it to me.

Comment 4

[Neeraj]

Attachment: Patch for this bug.

Hello Arthur,

I have created a pull request(https://github.com/mozilla-b2g/gaia/pull/9977) for this bug. Please review it :) 

Regards,

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Sorry for the delay. I did notice this request since I use an alias address [e-mail] in bugzilla. 

The patch works well. However, please address the comment from janjongboom in github. I would like to see your review request again, thanks!

Comment 6

[Neeraj]

Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Hello Arthur,

Thanks for reviewing :)

I have made the changes as mentioned in Github. Please review it again.

Regards,
Neeraj

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Thanks for the patch! However, the "P" should be lowercase. Please fix it before merging. r=me.

Comment 8

[Neeraj]

Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Hi Arthur,

Thanks for reviewing :)

I have updated pull request. Please review it again!

Regards,
Neeraj

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

r=me. Thank you!

Comment 10

[[e-mail]]

This patch does not landed. @arhtur is this issue still valid?

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

It seems the issue had been fixed.