[Settings] "Create a password" does not fit as a title for the Lock screen

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Settings
RESOLVED WONTFIX
5 years ago
3 years ago

People

(Reporter: nhirata, Assigned: Neeraj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: polish, uxbranch)

Attachments

(2 attachments)

Created attachment 702780 [details]
screenshot

## Environment :
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/f2460bf17811
Gaia   7258384661345ded5a8813c34774ef8a0b56cc02
BuildID 20130114230201
Version 18.0
Otoro/Unagi

## Repro :
1. go to settings
2. go to Phone lock
3. turn on Passlock
4. look at the title

## Expected :
1. the title fits in the screen

## Actual :
1. the title doesn't fit.

## Note :
Whiteboard: polish, uxbranch
What should the title say, maybe 'Set passcode'?

Comment 2

5 years ago
I can get this one. Not sure yet how to assign the ticket to myself here.
(Assignee)

Comment 3

5 years ago
I have resolved this bus.Please assign it to me.
(Assignee)

Comment 4

5 years ago
Created attachment 753692 [details] [diff] [review]
Patch for this bug.

Hello Arthur,

I have created a pull request(https://github.com/mozilla-b2g/gaia/pull/9977) for this bug. Please review it :) 

Regards,
Attachment #753692 - Flags: review?(achen)
Assignee: nobody → neeraj_kumar
Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Sorry for the delay. I did notice this request since I use an alias address arthur.chen@mozilla.com in bugzilla. 

The patch works well. However, please address the comment from janjongboom in github. I would like to see your review request again, thanks!
Attachment #753692 - Flags: review?(achen)
(Assignee)

Comment 6

5 years ago
Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Hello Arthur,

Thanks for reviewing :)

I have made the changes as mentioned in Github. Please review it again.

Regards,
Neeraj
Attachment #753692 - Flags: review?(arthur.chen)
Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Thanks for the patch! However, the "P" should be lowercase. Please fix it before merging. r=me.
Attachment #753692 - Flags: review?(arthur.chen) → review+
(Assignee)

Comment 8

5 years ago
Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

Hi Arthur,

Thanks for reviewing :)

I have updated pull request. Please review it again!

Regards,
Neeraj
Attachment #753692 - Flags: review+ → review?(arthur.chen)
Comment on attachment 753692 [details] [diff] [review]
Patch for this bug.

r=me. Thank you!
Attachment #753692 - Flags: review?(arthur.chen) → review+

Comment 10

4 years ago
This patch does not landed. @arhtur is this issue still valid?
Flags: needinfo?(arthur.chen)
It seems the issue had been fixed.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(arthur.chen)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.