831291 - GC: jsapi test Debugger fails under rooting analysis

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Attachment: Possible fix

I'm not sure about the use AutoArrayRooter in testIndirectEval.  I couldn't find anything else to root an array of jsval though.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 702818 [details] [diff] [review]
Possible fix

Review of attachment 702818 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testDebugger.cpp
@@ +160,5 @@
>      }
>  
>      js::RootedObject debuggeeWrapper(cx, debuggee);
>      CHECK(JS_WrapObject(cx, debuggeeWrapper.address()));
> +    js::RootedValue v(cx, OBJECT_TO_JSVAL(debuggeeWrapper));

Can you replace OBJECT_TO_JSVAL with ObjectValue? It's just a little cleaner.

@@ +198,5 @@
>      }
>  
>      js::RootedObject gWrapper(cx, g);
>      CHECK(JS_WrapObject(cx, gWrapper.address()));
> +    js::RootedValue v(cx, OBJECT_TO_JSVAL(gWrapper));

Same here.

Comment 3

[Jon Coppeard (:jonco) (PTO until 3rd April)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/935b891ba398

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/935b891ba398