Update RemoteTestRun class to support non-restart tests

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mario.garbi, Assigned: mario.garbi)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.75 KB, patch
whimboo
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Will upload a patch as soon as possible.
Hardware: x86 → All
Summary: Setting testrun.py so that it would run non-restart tests for RemoteTestRun → Update RemoteTestRun class to support non-restart tests
(Assignee)

Comment 1

6 years ago
Created attachment 703208 [details] [diff] [review]
patch v1.0

Linux testrun_remote reports:
http://mozmill-crowd.blargon7.com/#/remote/report/9e41582ed5e806fa373351d9d316a043
Attachment #703208 - Flags: review?(hskupin)
Attachment #703208 - Flags: review?(dave.hunt)
Attachment #703208 - Flags: review?(andreea.matei)
Comment on attachment 703208 [details] [diff] [review]
patch v1.0

Review of attachment 703208 [details] [diff] [review]:
-----------------------------------------------------------------

Tested and works as expected.
Thanks Mario
Attachment #703208 - Flags: review?(hskupin)
Attachment #703208 - Flags: review?(dave.hunt)
Attachment #703208 - Flags: review?(andreea.matei)
Attachment #703208 - Flags: review+
Keywords: checkin-needed
Comment on attachment 703208 [details] [diff] [review]
patch v1.0

Review of attachment 703208 [details] [diff] [review]:
-----------------------------------------------------------------

r- given the comment below. Also before we can get this landed the appropriate mozmill test has to be checked-in first.

::: libs/testrun.py
@@ +763,5 @@
>          """ Execute the normal and restart tests in sequence. """
>  
> +        try:
> +            self.restart_tests = False
> +            self.test_path = os.path.join('tests', 'remote', 'addonsTests')

Not sure why you have added addonsTests here. But that certainly breaks the testrun for future tests in other areas. Just comment in those lines and nothing more.
Attachment #703208 - Flags: review-
No longer blocks: 600291
Depends on: 600291
Keywords: checkin-needed
(Assignee)

Comment 4

6 years ago
Created attachment 703281 [details] [diff] [review]
patch v1.1

Fixed as requested
Linux - mozilla-default report :
http://mozmill-crowd.blargon7.com/#/remote/report/9e41582ed5e806fa373351d9d3185936
Attachment #703208 - Attachment is obsolete: true
Attachment #703281 - Flags: review?(hskupin)
Attachment #703281 - Flags: review?(dave.hunt)
Comment on attachment 703281 [details] [diff] [review]
patch v1.1

Review of attachment 703281 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Now we only have to wait for the test landed.
Attachment #703281 - Flags: review?(hskupin)
Attachment #703281 - Flags: review?(dave.hunt)
Attachment #703281 - Flags: review+
http://hg.mozilla.org/qa/mozmill-automation/rev/b6229a0e5320
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.