Closed
Bug 831306
Opened 12 years ago
Closed 12 years ago
Update RemoteTestRun class to support non-restart tests
Categories
(Mozilla QA Graveyard :: Mozmill Automation, defect)
Mozilla QA Graveyard
Mozmill Automation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mario.garbi, Assigned: mario.garbi)
References
Details
Attachments
(1 file, 1 obsolete file)
2.75 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
Will upload a patch as soon as possible.
Updated•12 years ago
|
Hardware: x86 → All
Summary: Setting testrun.py so that it would run non-restart tests for RemoteTestRun → Update RemoteTestRun class to support non-restart tests
Assignee | ||
Comment 1•12 years ago
|
||
Linux testrun_remote reports:
http://mozmill-crowd.blargon7.com/#/remote/report/9e41582ed5e806fa373351d9d316a043
Attachment #703208 -
Flags: review?(hskupin)
Attachment #703208 -
Flags: review?(dave.hunt)
Attachment #703208 -
Flags: review?(andreea.matei)
Comment 2•12 years ago
|
||
Comment on attachment 703208 [details] [diff] [review]
patch v1.0
Review of attachment 703208 [details] [diff] [review]:
-----------------------------------------------------------------
Tested and works as expected.
Thanks Mario
Attachment #703208 -
Flags: review?(hskupin)
Attachment #703208 -
Flags: review?(dave.hunt)
Attachment #703208 -
Flags: review?(andreea.matei)
Attachment #703208 -
Flags: review+
Updated•12 years ago
|
Keywords: checkin-needed
Comment 3•12 years ago
|
||
Comment on attachment 703208 [details] [diff] [review]
patch v1.0
Review of attachment 703208 [details] [diff] [review]:
-----------------------------------------------------------------
r- given the comment below. Also before we can get this landed the appropriate mozmill test has to be checked-in first.
::: libs/testrun.py
@@ +763,5 @@
> """ Execute the normal and restart tests in sequence. """
>
> + try:
> + self.restart_tests = False
> + self.test_path = os.path.join('tests', 'remote', 'addonsTests')
Not sure why you have added addonsTests here. But that certainly breaks the testrun for future tests in other areas. Just comment in those lines and nothing more.
Attachment #703208 -
Flags: review-
Updated•12 years ago
|
Assignee | ||
Comment 4•12 years ago
|
||
Fixed as requested
Linux - mozilla-default report :
http://mozmill-crowd.blargon7.com/#/remote/report/9e41582ed5e806fa373351d9d3185936
Attachment #703208 -
Attachment is obsolete: true
Attachment #703281 -
Flags: review?(hskupin)
Attachment #703281 -
Flags: review?(dave.hunt)
Comment 5•12 years ago
|
||
Comment on attachment 703281 [details] [diff] [review]
patch v1.1
Review of attachment 703281 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Now we only have to wait for the test landed.
Attachment #703281 -
Flags: review?(hskupin)
Attachment #703281 -
Flags: review?(dave.hunt)
Attachment #703281 -
Flags: review+
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•