Closed Bug 831306 Opened 12 years ago Closed 12 years ago

Update RemoteTestRun class to support non-restart tests

Categories

(Mozilla QA Graveyard :: Mozmill Automation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mario.garbi, Assigned: mario.garbi)

References

Details

Attachments

(1 file, 1 obsolete file)

Will upload a patch as soon as possible.
Hardware: x86 → All
Summary: Setting testrun.py so that it would run non-restart tests for RemoteTestRun → Update RemoteTestRun class to support non-restart tests
Attached patch patch v1.0 (obsolete) — Splinter Review
Attachment #703208 - Flags: review?(hskupin)
Attachment #703208 - Flags: review?(dave.hunt)
Attachment #703208 - Flags: review?(andreea.matei)
Comment on attachment 703208 [details] [diff] [review] patch v1.0 Review of attachment 703208 [details] [diff] [review]: ----------------------------------------------------------------- Tested and works as expected. Thanks Mario
Attachment #703208 - Flags: review?(hskupin)
Attachment #703208 - Flags: review?(dave.hunt)
Attachment #703208 - Flags: review?(andreea.matei)
Attachment #703208 - Flags: review+
Comment on attachment 703208 [details] [diff] [review] patch v1.0 Review of attachment 703208 [details] [diff] [review]: ----------------------------------------------------------------- r- given the comment below. Also before we can get this landed the appropriate mozmill test has to be checked-in first. ::: libs/testrun.py @@ +763,5 @@ > """ Execute the normal and restart tests in sequence. """ > > + try: > + self.restart_tests = False > + self.test_path = os.path.join('tests', 'remote', 'addonsTests') Not sure why you have added addonsTests here. But that certainly breaks the testrun for future tests in other areas. Just comment in those lines and nothing more.
Attachment #703208 - Flags: review-
No longer blocks: 600291
Depends on: 600291
Keywords: checkin-needed
Attached patch patch v1.1Splinter Review
Attachment #703208 - Attachment is obsolete: true
Attachment #703281 - Flags: review?(hskupin)
Attachment #703281 - Flags: review?(dave.hunt)
Comment on attachment 703281 [details] [diff] [review] patch v1.1 Review of attachment 703281 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Now we only have to wait for the test landed.
Attachment #703281 - Flags: review?(hskupin)
Attachment #703281 - Flags: review?(dave.hunt)
Attachment #703281 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: