831391 - Show less transparent homescreen / white window when hitting the home key / unlocking the phone

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This one is a very simple change that reduce the amount of transparent homescreen when you come back from an application to the homescreen. It also prevent many of the white application flash when going from the lockscreen to anywhere.

IMHO it really make the OS feels better.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Josh I really think you want this one.

Asking blocking+ because without this patch very often when you came out of an application the homescreen is transparent before it is beeing rendered and that gives a very bad feeling about the product on this particular interaction.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 702907 [details] [diff] [review]
Patch

Review of attachment 702907 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/homescreen/js/homescreen.js
@@ +56,5 @@
> +        }
> +
> +        var element = document.createElement('div');
> +        element.id = 'repaint-helper';
> +        document.body.appendChild(element);

Just toggling the css display property wasn't enough to force the repaint?

::: apps/system/js/lockscreen.js
@@ +521,3 @@
>  
> +    var repaintTimeout = 0;
> +    var nextPaint= function() {

lint nit

@@ +552,5 @@
> +    this.dispatchEvent('will-unlock');
> +    currentFrame.addNextPaintListener(nextPaint);
> +    repaintTimeout = setTimeout(function ensureUnlock() {
> +      nextPaint();
> +    }, 400);

shouldn't this one be the same than kTransitionTimeout in the window manager?

Comment 3

[Alex Keybl [:akeybl]]

Not a blocker since this is mostly cosmetic, but we will take in v1.0.x

Comment 4

[Etienne Segonzac (:etienne)]

/me can't wait for the updated version of the patch :)

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v2

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 703911 [details] [diff] [review]
Patch v2

Review of attachment 703911 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
(The nits are worth addressing ;))

::: apps/system/js/lockscreen.js
@@ +521,3 @@
>  
> +    var repaintTimeout = 0;
> +    var nextPaint= function() {

arrrrgggg, the lint error is still here ;)

::: apps/system/js/window_manager.js
@@ +71,4 @@
>    var screenElement = document.getElementById('screen');
>    var wrapperHeader = document.querySelector('#wrapper-activity-indicator');
>    var wrapperFooter = document.querySelector('#wrapper-footer');
> +  var kTransitionTimeout = 1000;

do we still need this bump since getting the repaint is sooo fast? :)

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/0c4274bf32ba13f5f82e2fc1720143d6e148f60d

1000 is to avoid as much as possible the transparent homescreen in bad cases.

Comment 8

[Josh Carpenter [:jcarpenter]]

Anything that reduces the amount of white-screen flashy-ness would be great. As you say, it makes the UI feel glitchy and cheap.

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #0)
> Created attachment 702907 [details] [diff] [review]
> Patch
> 
> This one is a very simple change that reduce the amount of transparent
> homescreen when you come back from an application to the homescreen.

Vivien, by transparent, do you mean the way in which the wallpaper shows first, but the other elements take a while to draw in?

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Josh Carpenter [:jcarpenter] from comment #8)
> Anything that reduces the amount of white-screen flashy-ness would be great.
> As you say, it makes the UI feel glitchy and cheap.
> 
> (In reply to Vivien Nicolas (:vingtetun) (:21) from comment #0)
> > Created attachment 702907 [details] [diff] [review]
> > Patch
> > 
> > This one is a very simple change that reduce the amount of transparent
> > homescreen when you come back from an application to the homescreen.
> 
> Vivien, by transparent, do you mean the way in which the wallpaper shows
> first, but the other elements take a while to draw in?

Yep that's what I meant.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

:/ the 300 to 1000 ms is causing wrapper footer disappears before app starts to do transition.
See https://bugzilla.mozilla.org/show_bug.cgi?id=849441#c0 (7)