Work - Grid layouts in panels are in one long row and can't be scrolled

RESOLVED FIXED

Status

Firefox for Metro
Browser
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=work [completed-elm])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 702925 [details] [diff] [review]
patch

This is related to bug 816256 but happens in the "PanelUI" views instead of the start page.  We need to call arrangeItems after the panel is shown so the grid can lay out based on the panel width and height.

This patch changes the "delayedInit" method for PanelUI views to "show" (which matches the StartUI views and is also just a better name), and calls arrangeItems from show where needed.
Attachment #702925 - Flags: review?(ally)
Comment on attachment 702925 [details] [diff] [review]
patch

Review of attachment 702925 [details] [diff] [review]:
-----------------------------------------------------------------

ship it!

for posterity:
- Adding the show() function for history & topsites is on me, as part of the refactor making bug 801000 happen.
- review questions answered in person, perk of workweek
Attachment #702925 - Flags: review?(ally) → review+
(Assignee)

Updated

5 years ago
Summary: Grid layouts in panels are in one long roll and can't be scrolled → Grid layouts in panels are in one long row and can't be scrolled
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/elm/rev/58f9d0035f74
Whiteboard: [metro-mvp][LOE:1][metro-it3] → [metro-mvp][LOE:1][metro-it3][completed-elm]

Updated

5 years ago
Summary: Grid layouts in panels are in one long row and can't be scrolled → Work - Grid layouts in panels are in one long row and can't be scrolled
Whiteboard: [metro-mvp][LOE:1][metro-it3][completed-elm] → feature=work [completed-elm]
(Assignee)

Comment 3

5 years ago
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.