[Browser] JS prompt does not focus on the field

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: nhirata, Assigned: rwaldron)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:-, b2g18+ fixed)

Details

(Whiteboard: uxbranch)

Attachments

(3 attachments)

Created attachment 702977 [details]
screenshot

## Environment:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/0a7c51803227
Gaia   a03f7b532e9998e646d55f93a0fc03a04d7ca7d9
BuildID 20130115230201
Version 18.0
Otoro/Unagi

## Repro :
1. launch browser
2. go to http://people.mozilla.com/~nhirata/html_tp/PasswordPrompt.html

## Expected :
focus should be in the text field, so that the keyboard pops up and the text in the field should be readable

## Actual :
focus is not on the text field; the contents of the field is not readable.
## Note :
Whiteboard: uxbranch
tracking-b2g18: ? → +
(Assignee)

Updated

6 years ago
Assignee: nobody → waldron.rick
(Assignee)

Updated

6 years ago
Summary: [Browser] JS Password prompt does not focus on the field and the contents is hard to read. → [Browser] JS prompt does not focus on the field
(Assignee)

Comment 1

6 years ago
Invoke elements.promptInput.focus(); to set focus and therefore a cursor on the prompt's input field.

https://github.com/mozilla-b2g/gaia/pull/8012
(Assignee)

Comment 2

6 years ago
Created attachment 711453 [details] [diff] [review]
Fix for 831457
Attachment #711453 - Flags: review?(bfrancis)
(Assignee)

Updated

6 years ago
blocking-b2g: --- → tef?
(Assignee)

Updated

6 years ago
Attachment #711453 - Flags: review?(bfrancis) → review?(nhirata.bugzilla)

Updated

6 years ago
blocking-b2g: tef? → -
Hi Rick, I'm not an official code reviewer.  It looks good to me though.  :)  I'll ping ben.
Flags: needinfo?(bfrancis)
(Assignee)

Updated

6 years ago
Attachment #711453 - Flags: review?(nhirata.bugzilla) → review?(dale)
Comment on attachment 711453 [details] [diff] [review]
Fix for 831457

That text field is really tiny! But that's outside the scope of this bug.

r+me.
Attachment #711453 - Flags: review?(dale) → review+
Flags: needinfo?(bfrancis)
(Assignee)

Comment 5

6 years ago
Created attachment 713917 [details]
Updated commit message

Adds r=benfrancis to commit message
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(In reply to Rick Waldron from comment #5)
> Created attachment 713917 [details]
> Updated commit message
> 
> Adds r=benfrancis to commit message

Rick, neither attachment has any git commit headers, fwiw.


[master 91fa372] Bug 831457 - [Browser] JS prompt does not focus on the field r=benfrancis

v1-train: 7b4d4ebb7a6d7ac3c16b0e9c81e31d77520699f8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-b2g18: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Testing in current nightly it seems this has regressed, opening http://people.mozilla.com/~nhirata/html_tp/PasswordPrompt.html doesnt show the keyboard
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: waldron.rick → nobody
Dale, this was changed in bug 863466
Ah so it did, reclose :)
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Assignee: nobody → waldron.rick
You need to log in before you can comment on or make changes to this bug.