831457 - [Browser] JS prompt does not focus on the field

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

## Environment:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/0a7c51803227
Gaia   a03f7b532e9998e646d55f93a0fc03a04d7ca7d9
BuildID 20130115230201
Version 18.0
Otoro/Unagi

## Repro :
1. launch browser
2. go to http://people.mozilla.com/~nhirata/html_tp/PasswordPrompt.html

## Expected :
focus should be in the text field, so that the keyboard pops up and the text in the field should be readable

## Actual :
focus is not on the text field; the contents of the field is not readable.
## Note :

Comment 1

[Rick Waldron [:rwaldron]]

Invoke elements.promptInput.focus(); to set focus and therefore a cursor on the prompt's input field.

https://github.com/mozilla-b2g/gaia/pull/8012

Comment 2

[Rick Waldron [:rwaldron]]

Attachment: Fix for 831457

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hi Rick, I'm not an official code reviewer.  It looks good to me though.  :)  I'll ping ben.

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 711453 [details] [diff] [review]
Fix for 831457

That text field is really tiny! But that's outside the scope of this bug.

r+me.

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: Updated commit message

Adds r=benfrancis to commit message

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Rick Waldron from comment #5)
> Created attachment 713917 [details]
> Updated commit message
> 
> Adds r=benfrancis to commit message

Rick, neither attachment has any git commit headers, fwiw.


[master 91fa372] Bug 831457 - [Browser] JS prompt does not focus on the field r=benfrancis

v1-train: 7b4d4ebb7a6d7ac3c16b0e9c81e31d77520699f8

Comment 7

[Rick Waldron [:rwaldron]]

https://github.com/rwldrn/gaia/commit/ba041542821705cbe18164ea80b9552964757cec.patch

Comment 8

[Dale Harvey (:daleharvey)]

Testing in current nightly it seems this has regressed, opening http://people.mozilla.com/~nhirata/html_tp/PasswordPrompt.html doesnt show the keyboard

Comment 9

[Ben Francis [:benfrancis]]

Dale, this was changed in bug 863466

Comment 10

[Dale Harvey (:daleharvey)]

Ah so it did, reclose :)