Closed Bug 831561 Opened 9 years ago Closed 9 years ago
Path Element should inherit from SVGElement
This code asserts: var clipPath = document.createElementNS("http://www.w3.org/2000/svg", "clipPath"); clipPath["hasExtension"].apply(clipPath,);
Assignee: nobody → dzbarsky
Attachment #703091 - Flags: review?(longsonr)
Comment on attachment 703091 [details] [diff] [review] Patch ClipPath elements are transformable. In SVG 2 they implement SVGTransformable so you need to add in the DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGLocatable); DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGTransformable); bits in clipPath that GRAPHIC_ELEMENT gave you. Please add the testcase as a crashtest and test the above transformable interface (by replacing hasExtension with transform I imagine). r=longsonr with the above things fixed.
Attachment #703091 - Flags: review?(longsonr) → review+
I already removed nsIDOMSVGLocatable and nsIDOMSVGTransformable because I forgot that ClipPath is transformable. I have patches that convert it to WebIDL bindings, so once I land those things will be ok again.
In that case, just comment 0 as a crashtest and then add a test that clipPath is transformable with the WebIDL clipPath patch.
Summary: Classinfo should not claim that ClipPathElement implements SVGTests → SVGClipPathElement should inherit from SVGElement
We can inherit from SVGTransformableElement in content to avoid code duplication, but we shouldn't expose that through dom bindings.
Attachment #705144 - Flags: review?(longsonr) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.