831561 - SVGClipPathElement should inherit from SVGElement

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[David Zbarsky (:dzbarsky)]

This code asserts:
var clipPath = document.createElementNS("http://www.w3.org/2000/svg", "clipPath");
clipPath["hasExtension"].apply(clipPath,[]);

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 703091 [details] [diff] [review]
Patch

ClipPath elements are transformable. In SVG 2 they implement SVGTransformable so you need to add in the 

    DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGLocatable);
    DOM_CLASSINFO_MAP_ENTRY(nsIDOMSVGTransformable);

bits in clipPath that GRAPHIC_ELEMENT gave you.

Please add the testcase as a crashtest and test the above transformable interface (by replacing hasExtension with transform I imagine).

r=longsonr with the above things fixed.

Comment 3

[David Zbarsky (:dzbarsky)]

I already removed nsIDOMSVGLocatable and nsIDOMSVGTransformable because I forgot that ClipPath is transformable.  I have patches that convert it to WebIDL bindings, so once I land those things will be ok again.

Comment 4

[Robert Longson [:longsonr]]

In that case, just comment 0 as a crashtest and then add a test that clipPath is transformable with the WebIDL clipPath patch.

Comment 5

[David Zbarsky (:dzbarsky)]

Attachment: Patch

We can inherit from SVGTransformableElement in content to avoid code duplication, but we shouldn't expose that through dom bindings.

Comment 6

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03c3ae8323bd

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Backed out for Windows bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9ae5e6cd9b
https://tbpl.mozilla.org/php/getParsedLog.php?id=19230027&tree=Mozilla-Inbound

Comment 8

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29c7a6d9ec8b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29c7a6d9ec8b