Closed Bug 831623 Opened 10 years ago Closed 10 years ago
Symbol Response and fetch Symbol to a new class so it can be used for late write stacks too
No description provided.
Attachment #703137 - Flags: review?(vdjeric)
Attachment #703137 - Flags: review?(vdjeric) → review-
10 years ago
Summary: Generalize handleSymbolResponse so it can be used for late write stacks too → Move handleSymbolResponse and fetchSymbol to a new class so it can be used for late write stacks too
I have tested that symbolication works on the mac. It is building on windows and I will test it tomorrow.
10 years ago
Attachment #703137 - Attachment is obsolete: true
Patch looks good, although I want to take another look in the morning. What do you think of checking symbolRequest.readyState and symbolRequest.status in SymbolicationRequest.handleSymbolResponse? Then handleSymbolResponse would either 1) return immediately (if readyState != 4), 2) call StackRenderer.renderSymbolicatedStacks (if status = 200), or 3) call StackRenderer.showErrorMessage (if status != 200). That way all XMLHttpRequest logic is in SymbolicationRequest and StackRenderer just renders stuff it's told to render.
The hang code was missing an 's' (hang instead of hangs). That is the only difference is this patch. There is only one call to renderSymbolicatedStacks, so we can inline as much of it as you want without duplicating code, but we should probably do it in a followup bug.
Attachment #703871 - Flags: review?(vdjeric) → review+
Filed bug 832693 for the SymoblicationRequest change
Rafael is on vacation, so I landed this patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/077caacae057
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
(In reply to Vladan Djeric (:vladan) from comment #6) > Rafael is on vacation, so I landed this patch: > > https://hg.mozilla.org/integration/mozilla-inbound/rev/077caacae057 Thanks!
You need to log in before you can comment on or make changes to this bug.