Closed Bug 831750 Opened 7 years ago Closed 7 years ago

GC: testConservativeGC jsapi test fails with rooting analysis

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 831376
Attached patch Potential fix (obsolete) — Splinter Review
Attached patch Better fixSplinter Review
After talking to Terrence we decided that this test is not appropriate for rooting builds and we will just disable it.  Anchors will be added to our list of things to root properly in the browser.
Attachment #703342 - Attachment is obsolete: true
Attachment #704499 - Flags: review?(terrence)
Comment on attachment 704499 [details] [diff] [review]
Better fix

Review of attachment 704499 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testConservativeGC.cpp
@@ +7,5 @@
>  #include "vm/String.h"
>  
>  #include "jsobjinlines.h"
>  
> +#if !defined(JSGC_ROOT_ANALYSIS) && !defined(JSGC_USE_EXACT_ROOTING)

Move this up to right below the license: it will make compiling this file epsilon faster.
Attachment #704499 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/bedb55033fe7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.