831783 - Clean up event constants

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

There's a bunch of event constants in GeckoEvents.java that are not used, and some in the XUL fennec GeckoEvents that are horribly out of date. Patch attached. Try build running at https://tbpl.mozilla.org/?tree=Try&rev=2b061861aa1e

Presumably this patch won't break XUL fennec any more than it is already broken, and hopefully will actually fix some things and/or make it more consistent.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 703344 [details] [diff] [review]
Patch

Review of attachment 703344 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoEvent.java
@@ +46,5 @@
>      public static final int BROADCAST = 19;
>      public static final int VIEWPORT = 20;
>      public static final int VISITED = 21;
>      public static final int NETWORK_CHANGED = 22;
> +    public static final int SCREENORIENTATION_CHANGED = 27;

Since this is out of sequence, may be worth commenting that it's set to match the one in mobile/android/GeckoEvent.java?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Added a comment as requested, landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/48c0d6ebc3d5

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/48c0d6ebc3d5