8318 - pop ups obliterate personal toolbar

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P3)

Description

[Michael La Guardia]

Go to home.netscape.com or some other site that uses pop-ups.  You may need to hit reload a couple of times to get a pop-up to appear.  When it does, the personal toolbar in the main window disappears, never to be seen again (view|toolbars does not appear to be hooked up).

Comment 1

[don]

Peter, this does indeed happen on Windows although I can't reproduce the problem
on Linux.  This isn't really an XPApps issue but more of a Javascript and
"window.open" problem.  Is Hyatt still workin on that?

Comment 2

[Peter Trudelle]

Sounds like he may need to, reassigning.

Comment 3

[David Hyatt]

This probably has something to do with Dan's chrome changes.  I'm assuming the
wrong webshell is being targeted (the original one instead of the new popup).

Comment 4

[Dan M]

Better test case: executing the JS

window.open("whatever", "new", "toolbar=no")

will cause the problem, while an identical line with toolbar=yes will not.

Comment 5

[Dan M]

The "chrome hidden" flag is copied between the open browser windows for the personal toolbar,
which comes from an RDF datasource.  The new window.open window is, yes, just another browser
window.  I hope this isn't an architectural problem, but I fear it is.  More later.

Comment 6

[David Hyatt]

The personal toolbar should be using a "ref" attribute rather than an "id"
attribute to point to the RDF data.  This will solve your problem.

Comment 7

[Dan M]

Amid worries that the attribute causing the DOM node to be hidden is being set
in the wrong datasource, this bug finds a new home in the RDF camp.

Comment 8

[Dan M]

There's a workaround in the code now.  While the bug itself isn't yet fixed, you can
at least use the menu to get back the missing toolbar.

Comment 9

[Dan M]

*** Bug 9108 has been marked as a duplicate of this bug. ***

Comment 10

[Chris Waterson]

So what was happening here is this. The generic builder on the personal toolbar
was allowing this assertion to be accepted into the local store. Wham-o, all of
a sudden everyone sees it. I removed the local store from the generic builder
for now: RJC will this break you in any way?

Comment 11

[Robert John Churchill]

Doubt it... go for it.

Comment 12

[rubydoo123]

[071699] can't get pop ups to appear, so I can't verify this one. It will have
to wait until I can duplicate the problem.

Comment 13

[rubydoo123]

although it takes the pop-up a while to close, it did not obliterate the
toolbars