Variables View: editing getters and setters should not be allowed

RESOLVED FIXED in Firefox 21

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: msucan, Assigned: vporof)

Tracking

Trunk
Firefox 21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Currently the variables view allows users to edit getters and setter, however they are not properly updated.
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P3
(Assignee)

Comment 1

5 years ago
If we're ever going to allow this, let's do it in a different bug.
Summary: Variables View: editing getters and setters does not work → Variables View: editing getters and setters should not be allowed
(Assignee)

Updated

5 years ago
Depends on: 830715
(Assignee)

Comment 2

5 years ago
Created attachment 705565 [details] [diff] [review]
v1

Easy peasy.
Attachment #705565 - Flags: review?(rcampbell)
Comment on attachment 705565 [details] [diff] [review]
v1

does this need a TODO or forward bug reference?

r+
Attachment #705565 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 4

5 years ago
Added note to bug 831794.
(Assignee)

Comment 5

5 years ago
Created attachment 705890 [details] [diff] [review]
v1.1
Attachment #705890 - Flags: review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/add340e8b076
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/add340e8b076
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
You need to log in before you can comment on or make changes to this bug.