831874 - [B2G][Gallery] Able to bring up Share options for a photo that has been deleted already.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Cody Roesch [:croesch]]

Attachment: Gallery Photo UI.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130104151925

Steps to reproduce:

1. Launch Unagi build 20130117070201 Version 18.0
2. Take a photo.
3. Go to gallery
4. Tap on your photo
5. Notice the Share button is right next the delete button.
6. Tap the delete button to bring up the delete confirmation dialog.
7. Quickly double tap the very left side of the OK button above where the Share button was located on the previous screen.
8. Notice that the photo will get deleted but because you double tapped, the share button will have been activated.
9. You now have share options for a photo that has been deleted.

Repro 5/5 on multiple devices. You must follow these exact steps or you may not get the bug described.


Actual results:

Double tapping on the left side of the OK button to delete a photo allows the user to bring up share options for a photo that no longer exists.


Expected results:

Even double tapping  on OK when deleting a photo should have a buffer so the photo can be deleted and nothing else can take place such as tapping on other buttons.

Comment 1

[Cody Roesch [:croesch]]

Attachment: Delete Photo Screen

Comment 2

[Cody Roesch [:croesch]]

Unagi Build 20130225070200
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia   5691a16fff8e1403c75ed9d6f3a443b7e58198c6
Kernal Dec 5th

In this build, the behavior changes just a bit. The user can still bring up options for a deleted photo but the photo is no longer seen but instead, the user can manipulate options for a black image.

If I follow the steps, I can set a black screen as a wallpaper which is basically just the deleted photo.
However a real problem occurs if trying to send the deleted photo via Bluetooth. You will be asked if you want to send the photo but the process seems to hang after the attempt to send. A black screen will appear with no other indications of the state of the transfer.

Steps
1. Pair the test device with another device via bluetooth.
2. Launch Gallery
3. Tap on a photo to zoom in on the photo and see various options for the photo.
4. Tap the delete button to bring up the confirmation message.
5. Double tap on the OK button right where the Share button would normally be.
6. This will bring up the Share menu.
7. Tap on Bluetooth Transfer.
8. Confirm the transfer to the second device.
9. Notice that the screen is now completely black with no indication of the state of the transfer.
10. Notice the transfer never occurs.

Comment 3

[Dietrich Ayala (:dietrich)]

event leaking from apps into system ui, and other bad stuff. blocking for investigation.

Comment 4

[[e-mail]]

To avoid the miss operations (share/delete just-deleted item) that while file is deleting, I would let Share button and delete button disabled a certain time, and enable those button again.

Comment 5

[[e-mail]]

Attachment: Disabled Share button and delete button a certain time while file is deleting.

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 723366 [details]
Disabled Share button and delete button a certain time while file is deleting.

Fred, djf is busy so I stolen this review from him.

I think use window.setTimeout() cannot guarantee the deleted image is gone and ready to show next/previous image, so it will be better to re-enable the share button after we show a image that does exist, like we discussed in offline.

I will cancel the review request first and you can re-assign to the reviewers or me again aftere you update your patch, thanks.

Comment 7

[[e-mail]]

Attachment: disable delete and share button in deleteFile, and bring them back in showFile

Thanks Dominic, I found there's an existing approach to deal with edit button in showFile. So I changed the pull request to use the same approach.

Comment 8

[Dominic Kuo [:dkuo]]

Comment on attachment 724777 [details]
disable delete and share button in deleteFile, and bring them back in showFile

looks good, r+.

And please remeber to squash your commits into one, also I have noticed the travis build failed on your commits, so you might also need to rebase your branch to the latest gaia master, let's wait for the travis pass and we should be good to land this, thanks.

Comment 9

[[e-mail]]

Squashed and pass the travis build.

merged to master-gaia 
https://github.com/mozilla-b2g/gaia/commit/f1be6cca93a6a441c41ae07a80ab31e746d60b97

Thanks!

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit f1be6cca93a6a441c41ae07a80ab31e746d60b97 as:
v1-train: f91a6529a17e0704362eaed5198051d54044ab16

Comment 11

[Cody Roesch [:croesch]]

Unagi Build ID: 20130319070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/406b86b4b515
Gaia: c5a8b6476f0dbc456061227a7801e56634683eb0
Update Channel: Nightly

I am no unable to get the share button to appear if I quickly double tap the delete button when deleting a photo. Marking as Worksforme.

Comment 12

[Cody Roesch [:croesch]]

Unagi Build ID: 20130328070202
Kernel Date: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/c516d7e67150
Gaia   d40dcdd112f12e2a5a0d1de46451670918fd4369
Update Channel: Nightly

I want to clarify that I found the fix worked for V1. However the bug still exists in V1.0.1. because it has not reached v1.0.1 train yet. I'm attaching a new screenshot based on todays build and a new screen another tester has seen. Using the same test steps.

Comment 13

[cbarker]

Resolving Fixed

Comment 14

[Nick Davidson]

Attachment: step by step screens of deleting and shearing image.

This is the behavour we saw today See attachment Pic.
 Regular behavor as described in a bug can be seen in this video:  http://youtu.be/08_FDCTwG4s

Comment 15

[Angela Hubenya]

UCID: gallery-024
Test Case has been updated