831953 - WiFi Tethering should use a unique Network Name (SSID)

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Using a unique network name prevents the bad guys from building 'rainbow tables' to speed up cracking WPA passwords. This is common practice for devices that use the same network name like 'linksys' or 'default'.

It would also lead to less confusion if two people in the same range use a FirefoxOS phone as a hotspot.

Ideally we simply add some unique text to the network name.

Comment 1

[Stephanie Ouillon [:arroway] (needinfo me)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15197

Comment 2

[Fabien Cazenave [:kaze]]

Do you think it would make sense to change the SSID if we detect it’s set to `FirefoxHotSpot`? It would add a couple JS lines, but it would protect our ≤ 1.3 users when they update to 1.4.

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 8358799 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15197

LGTM, but this patch raises a UX issue: the SSID name does not fit in the “Internet Sharing” panel any more. Please either fix this (with some UX help) and re-flag me, or open a follow-up and land it.

Comment 4

[Stephanie Ouillon [:arroway] (needinfo me)]

Thanks, I'll fix that before landing it.

Comment 5

[Stephanie Ouillon [:arroway] (needinfo me)]

Attachment: 1.FirefoxHotspot_truncated.png

Comment 6

[Stephanie Ouillon [:arroway] (needinfo me)]

Attachment: 2.FirefoxOS_full.png

I updated the PR with small changes to the UI. I changed the default name from "FirefoxHotpost_*****" to "FirefoxOS_*****" because a smaller name was needed and changed some CSS bits.

Comment 7

[Stephanie Ouillon [:arroway] (needinfo me)]

It doesn't seem there is anyone being the ui-review? flag, any idea who I could ping?

Comment 8

[Stephanie Ouillon [:arroway] (needinfo me)]

Evelyn, I see you're module owner, could you tell me who I can ping to make things move for this bug?

Comment 9

[Evelyn Hung]

Comment on attachment 8377056 [details]
2.FirefoxOS_full.png

Hi Omega, can you take a look and provide some feedback? Thanks.

Comment 10

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8377056 [details]
2.FirefoxOS_full.png

Please use list item with second line for Name and Security.

Comment 11

[Omega Feng [:Omega] [:馮於懋]]

Attachment: [1.5 Settings] Internet Sharing v1.0.pdf

Please use list item with second line for Name and Security.

Comment 12

[Stephanie Ouillon [:arroway] (needinfo me)]

Thx, I'll fix that;

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] HafidTraikzi:Bug_831953 > mozilla-b2g:master

Comment 14

[Hafid]

Attachment: https://github.com/mozilla-b2g/gaia/pull/28811

Comment 15

[Frederik Braun [:freddy]]

Comment on attachment 8576132 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/28811

jaao suggested this should be reviewed by Arthur.

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8576132 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/28811

Good work! r=me with the comments addressed, thanks.

Comment 17

[Hafid]

I have edited the patch to address your comments.

Thanks. :)

Comment 18

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#MfS2hEbMQbmBGy0BcHK70w

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 19

[Hafid]

I updated my pull request... because my gaia's fork was not updated.

Comment 20

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#Ovn9y9dGS4KwZODjo8b9-A

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 21

[Frederik Braun [:freddy]]

Hafid, if you do not see something actionable from the test results (I say this, because I cannot see the error logs myself), you can re-trigger a test-run by either re-basing from master again or closing & reopening your pull request on GitHub.

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] HafidTraikzi:Bug_831953 > mozilla-b2g:master

Comment 23

[Hafid]

https://github.com/mozilla-b2g/gaia/pull/30094

Comment 24

[[e-mail]]

need some work to land the patch