Closed Bug 831958 Opened 7 years ago Closed 7 years ago

Story - Access the Options Flyout

Categories

(Tracking Graveyard :: Metro Operations, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: asa, Assigned: bbondy)

References

Details

(Keywords: qawanted, Whiteboard: feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8)

Attachments

(4 files)

No description provided.
Priority: -- → P2
Whiteboard: c=Settings_pane_options_and_about u= p= → c=Settings_pane_options_and_about u=metro_firefox_user p=
Whiteboard: c=Settings_pane_options_and_about u=metro_firefox_user p= → c=Settings_pane_options_and_about u=metro_firefox_user p=8
Assignee: nobody → mbrubeck
OS: Windows 8 → Windows 8 Metro
Summary: Access the Options Flyout → Story - Access the Options Flyout
Whiteboard: c=Settings_pane_options_and_about u=metro_firefox_user p=8 → feature=story status=for_sprint c=Settings_pane_options_and_about u=metro_firefox_user p=8
Status: NEW → ASSIGNED
Attached image mockup
This mockup was posted by Yuan at yesterday's team meeting.
Depends on: 835518
Depends on: 835615
Some questions about the mockup:

* Startup: we currently offer "blank page" and "use current page" options.  Should we remove those, or keep them?  (Setting a custom home page is one of the few browser customizations that is actually widely used.)

* Sync: We don't have the ability to choose which devices to sync with; we can only let you connect or disconnect to your Firefox Sync account.

* Clear Browsing History: Currently we have a "Clear Private Data" button which clears history, passwords, cookies, site permissions, form data, etc.  The user stories call for both "Clear History" and "Clear Private Data".

  Do we want one button to clear all data and another for just history? Or should we have a single button that offers a choice of data (like Firefox for desktop and Firefox for Android)?

* Site Permissions: Do we really need this global toggle for geolocation?  Geolocation is already disabled by default unless a user opts in for a specific site, and the Windows "Permissions" pane can block it for the whole browser.

  We also have several other site permissions; do we plan to add global toggles for each of them?

* Cookies: Should we remove the "Allow cookies" preference?  Expect some backlash if we do.  (I'd like to remove this not-very-useful pref, but maybe we should wait until we finish our third-party-cookie-blocking work, so we have a better privacy story.)

Most of the items here have their own stories which may need to be updated to reflect any changes we make here:
https://bug45311.bugzilla.mozilla.org/attachment.cgi?id=701924#P-76bbec1e-f9e0-4a38-8daa-b6cf7eda5dc6

For this story, I'll just make the basic layout and style changes.  Changes to the individual prefs will be covered by other stories.
Flags: needinfo?(ywang)
Depends on: 836421
*Startup: 
I think we should remove these two options.

The FX Start is designed to be a personal, live start place. It feels like part of the browser itself instead of a simple page. For users would like to launch a certain website quickly from start, their goal could be met by pinning a site to the Windows Start screen as a secondary tile.

* Sync [Will get back to you later about this with an updated mockup]


* Clear Browsing History
From the user stories, I thought "Clear History" and "Clear Private data" are two separate features. Having a choice of data and time range is over complicated for Metro use case, at least v1.

I am okay with going simple for V1. "Clear History" and with a description underneath "This will clear all your browsing history, passwords, cookies, site permissions, and form data on your Metro/Windows 8 Firefox(term to be determined)."

Currently this sounds a bit drastic. But once we have a private browsing mode in Metro, and delete individual history tile in History page. Users should feel having better control over their history data. 

  
* Site permissions
I think we should have this option. From the user story UC-18-3, FX doesn't bring back the info bar, and allow the user to make changes on the previous granted permissions.

In some cases when the user have chosen to always share his geolocation on a specific site, currently there is no access to info bar, in order to change the decision the user granted. So, a global site permission reset will be useful to start over and bring the info bar back next time the user visits the site. 

For users who always keep their permission of geolocation off in the "Permission" pane, we should grey out the "Clear permissions" section.  


*Cookies
Agree. We should remove this eventually, after the related work is done.
Flags: needinfo?(ywang)
(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> Some questions about the mockup:
> 
> * Startup: we currently offer "blank page" and "use current page" options. 
> Should we remove those, or keep them?  (Setting a custom home page is one of
> the few browser customizations that is actually widely used.)

We remove these. There is no other option. Users can pin sites to Windows Start and launch from that if they want a different start page.

> * Clear Browsing History: Currently we have a "Clear Private Data" button
> which clears history, passwords, cookies, site permissions, form data, etc. 
> The user stories call for both "Clear History" and "Clear Private Data".
> 
> Do we want one button to clear all data and another for just history? Or
> should we have a single button that offers a choice of data (like Firefox
> for desktop and Firefox for Android)?

I was looking at Clear *just* History when I thought we couldn't get the clear private data feature with data type and date range selections. If we can't get the Clear Private Data like other Firefoxes, then a "clear just history" is a reasonable first step that will give most users a way to cover their surfing tracks sufficiently for a v1.

> * Site Permissions: Do we really need this global toggle for geolocation? 
> Geolocation is already disabled by default unless a user opts in for a
> specific site, and the Windows "Permissions" pane can block it for the whole
> browser.

I think we do without this because we're going to get a big hammer "clear all site permissions" for the case that you've shared and you want to revoke it. 

>   We also have several other site permissions; do we plan to add global
> toggles for each of them?

We may eventually add global toggles for all but not for v1. 

> * Cookies: Should we remove the "Allow cookies" preference?  Expect some
> backlash if we do.  (I'd like to remove this not-very-useful pref, but maybe
> we should wait until we finish our third-party-cookie-blocking work, so we
> have a better privacy story.)

Remove for sure. 
 
> Most of the items here have their own stories which may need to be updated
> to reflect any changes we make here:
> https://bug45311.bugzilla.mozilla.org/attachment.cgi?id=701924#P-76bbec1e-
> f9e0-4a38-8daa-b6cf7eda5dc6
> 
> For this story, I'll just make the basic layout and style changes.  Changes
> to the individual prefs will be covered by other stories.

Sounds good.
Depends on: 836798
Depends on: 836821
Blocks: metrov1it1
Attached image updated mockup
Update the mockup of option flyout.
Major changes:
1. Used 2nd person or instead 1st person.
"Tell websites not to track you", "Remember passwords"

2. Removed the global toggle for geolocation

3. Updated "Clear History", added description

4. Changed titles and actions to upper case: 
"Pair a Device", "Sync Now"

5. Updated the states of Sync

6. Updated switch status to indicate the default state
Thanks for the updated mockup?

(In reply to Yuan Wang(:Yuan) – Firefox UX Team from comment #5)
> 1. Used 2nd person or instead 1st person.
> "Tell websites not to track you", "Remember passwords"

We use first-person for DNT and other prefs on both Desktop and Android.  Is there a reason to switch in Metro?

I don't see a strong trend toward second-person in other Metro Apps.  The built-in People app uses first-person ("Sort my contacts"); the Store app uses a mix of first- and second-person ("Your account", "find apps in my preferred languages").  Skype uses first-person, while IE uses second-person.

Given this, I'd rather keep consistency with Firefox across platforms than try to be consistent with "Metro."

> 3. Updated "Clear History", added description

Should we also change the name to "Clear Private Data" (matches Firefox for Android, and is a bit more accurate for the described functionality)?

Note: We can cover this in the separate "Clear History" and "Clear Private Data" user stories.

Yuan: Can you please file individual bugs for each of the changes 1-6?
No longer blocks: metrov1it1
Whiteboard: feature=story status=for_sprint c=Settings_pane_options_and_about u=metro_firefox_user p=8 → feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8
Assignee: mbrubeck → netzen
Blocks: metrov1it2
No longer blocks: metrov1backlog
I only heard about Bug 835615 being reported in testing this feature and that should be fixed now, so resolving this.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
I'd love to have some early testing for this feature to see if anything else is needed to keep this story closed out (which I could tackle on this same iteration).
Keywords: qawanted
Whiteboard: feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 → feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 status=for_testing
(In reply to Brian R. Bondy [:bbondy] from comment #8)
> I'd love to have some early testing for this feature to see if anything else
> is needed to keep this story closed out (which I could tackle on this same
> iteration).

I'll get on this testing ASAP.
I am no longer seeing the failures in opening the Options and About Flyouts that I was seeing a week ago in Iteration#1 testing. With Elm nightly (2013-02-09) Built from http://hg.mozilla.org/projects/elm/rev/6b7200b41efb the Flyouts work as expected.
Whiteboard: feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 status=for_testing → feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8
Attached image [Mockup] Options_v5
Changes on this latest mockup:
1. Removed Sync from Options flyout and leveled it up to the top level
2. Added Import Data to Options flyout
3. Changed the state of "Action complete" for actions buttons. Button label will be greyed out when the action is done. 
4. Used 2nd person
Tested on 2013-02-13 Nightly built from http://hg.mozilla.org/mozilla-central/rev/aceeea086ccb
- I've tested that the Options Flyout works as described in the story, both a tablet an touchscreen laptop.

1. However, the story and the latest mockups don't match. There are also problems when opening the elements in the panel (like clear history) which displays a notification that cannot be made to disappear at the moment.

Strictly speaking, the Options Flyout comes in and out as expected, but I would like to know if that's the extent of the scope (and mark this as verified) or if we should reopen and work on [1].
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 → feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 status=verified
Whiteboard: feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 status=verified → feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 status=for_testing
I think that the remaining issues/changes are outside the scope of this story.  The problem with the dialog buttons affects all modal dialogs (bug 840855 and duplicates).  The mockup differences are covered by other stories like bug 831960 or should be filed as change stories (many already have, like bug 841480 and bug 841511) since they were not in the spec for this story.
(In reply to Matt Brubeck (:mbrubeck) from comment #13)
> I think that the remaining issues/changes are outside the scope of this
> story.  The problem with the dialog buttons affects all modal dialogs (bug
> 840855 and duplicates).  The mockup differences are covered by other stories
> like bug 831960 or should be filed as change stories (many already have,
> like bug 841480 and bug 841511) since they were not in the spec for this
> story.

Matt, you are correct. Juan and I talked about this today and I'm confident we've got coverage for these issues in other stories or changes. 

Verified with 2014-02-14 m-c build
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Depends on: 841511
Depends on: 841572
No longer depends on: 841511
Whiteboard: feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8 status=for_testing → feature=story c=Settings_pane_options_and_about u=metro_firefox_user p=8
Depends on: 841511
Component: General → Metro Operations
Product: Firefox for Metro → Tracking
Version: unspecified → ---
Depends on: 849332
Depends on: 849608
No longer depends on: 849332
Found a defect in the following story when going through the extra steps outlined below. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-03-26-03-09-41-mozilla-central/

Added the following extra steps:

- When closing Metro Firefox using the application bar on the left of the screen, no settings are saved. The settings should be saved when the application is relaunched.

I will post a defect for this issue.
Depends on: 855147
Depends on: 854077
Depends on: 872159
Depends on: 872163
Depends on: 882504
Depends on: 876816
Depends on: 865519
Depends on: 876191
Depends on: 846422
Depends on: 898457
Depends on: 897121
Depends on: 900239
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130808030205
Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0

WFM
Tested on windows 8 using latest nightly  for iteration-11. Followed steps provided in user story and got expected result.
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in user story and got expected result.
Depends on: 941026
No longer depends on: 941026
Depends on: 971081
OS: Windows 8 Metro → Windows 8.1
Product: Tracking → Tracking Graveyard
You need to log in before you can comment on or make changes to this bug.