832002 - Get hwc enabled in Moz builds

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Nick and I found that enabling hwc in default moz builds results in crashes.

Two stages here
 (1) Flip the hwc pref on, but leave the propdb setting for color layers off.

For this we just need to sort the crash.

 (2) Enable the propdb setting for color layers.

For this, we need
 A. Import the downstream patch to hardware/qcom/display/libhwcomposer/ into our queue.
 B. Ensure our kernels have the requisite changes.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I had totally forgotten about this.  dwilson reminded me that we reverted a CAF downstream change to the hwc_layer_t ABI in gecko.  However, we're still using a gonk that has that ABI fork.  These patches revert it at the gonk layer

https://www.codeaurora.org/gitweb/quic/lf/?p=b2g/build.git;a=commit;h=9252cceacfebf656bc55065a6e586bf3024a3c72

We need to get these pulled into our patch queue, appropriately rebased.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: patch 1

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: patch 2

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: patch 3

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: patch 4

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This is round 1 of the gonk patches we need to enable hwc.  With these I get a functional hwc.

jhford, can we get these into our otoro and unagi patch queues?  (Not sure how that's set up atm.)

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(Note: all these patches can land at any time because they don't affect anything until the gecko hwc pref is flipped.)

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #6)
> This is round 1 of the gonk patches we need to enable hwc.  With these I get
> a functional hwc.
> 
> jhford, can we get these into our otoro and unagi patch queues?  (Not sure
> how that's set up atm.)

Yep, I'll take care of this.  As things are set up right now, we don't really have the ability to say that a given set of patches are for a specific device, but I'll add that in right now.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Ok, I've landed these patches into the gonk-patches repository.  I've not yet added that repository to our manifests yet, but if this looks good, I'll do that straight away.

To test the patches (and patching infrastructure), you can clone gonk-patches into your top level B2G directory.  The build.sh script will see the patching script and work properly, if you do:

git clone [e-mail]:mozilla-b2g/gonk-patches.git patches

Chris, if this looks good for you, I'll add gonk-patches to the master and nightly otoro and unagi manifests.

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(I haven't forgotten about this but we're blocked on getting a kernel with proper colorfill support.)

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #10)
> (I haven't forgotten about this but we're blocked on getting a kernel with
> proper colorfill support.)

roger.

How does the gonk-patches repository look?  I've been doing all of my local builds with it enabled and so far it hasn't broken.

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Seems ok to me.

Comment 13

[Michael Wu [:mwu]]

Requisite patches for hwc color layer support on Buri/Leo was landed in bug 862397.