Closed Bug 832012 Opened 13 years ago Closed 13 years ago

DASH: Fix CompareRepresentationBitrates; implementation and use

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: sworkman, Unassigned)

Details

Attachments

(1 file)

CompareRepresentationBitrates is not implemented consistently or used correctly. 1. The comparator is not included in the call to Contains, which is in the line above the call to InsertElementSorted (in AdaptationSet::AddRepresentation()). 2. The implementations of Equals and LessThan are not consistent.
Attached patch patch — — Splinter Review
Attachment #729924 - Flags: review?(sworkman)
Hi Andrew! Thanks for the patch - unfortunately, DASH work in Gecko has been recently halted (See Bug 702122 Comment 10). This bug escaped my attention and I haven't closed it out yet - sorry about that!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Attachment #729924 - Flags: review?(sworkman)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: