832063 - IonMonkey: tidy up flush/finish

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: patch

Comment 1

[Marty Rosenberg [:mjrosenb]]

Comment on attachment 703635 [details] [diff] [review]
patch

Review of attachment 703635 [details] [diff] [review]:
-----------------------------------------------------------------

Is this to align the definitions of flush() and finish() on arm and x86, since arm has both, and x86 should only have one of the two?

::: js/src/ion/IonLinker.h
@@ -29,5 @@
>      }
>  
>      IonCode *newCode(JSContext *cx, IonCompartment *comp) {
>          AssertCanGC();
> -#ifndef JS_CPU_ARM

Shouldn't this be #ifdef JS_CPU_ARM?

Comment 2

[Luke Wagner [:luke]]

I don't understand that question; are you asking why the code was removed or why it was originally the way it was?

Comment 3

[Luke Wagner [:luke]]

(In reply to Marty Rosenberg [:mjrosenb] from comment #1)
> Is this to align the definitions of flush() and finish() on arm and x86,
> since arm has both, and x86 should only have one of the two?

Yeah, the goal is to have one "finish()" called in one place, rather than two finish-like calls called in 2 different places, one surrounded by an #ifdef.

Comment 4

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/879677a0aa37

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/879677a0aa37