IonMonkey: don't use resume point to iterate over phis

RESOLVED FIXED in mozilla21

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 703639 [details] [diff] [review]
patch

It seems more direct to iterate over phisBegin()/phisEnd() directly.  This is good for OdinMonkey, which never creates resume points.
Attachment #703639 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #703639 - Flags: review? → review?(sstangl)
Comment on attachment 703639 [details] [diff] [review]
patch

Review of attachment 703639 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/MIRGraph.cpp
@@ +674,5 @@
>  
>          if (!entryDef->addInput(exitDef))
>              return false;
>  
> +        setSlot(entryDef->slot(), entryDef);

Wouldn't hurt to JS_ASSERT(entryDef->slot() < pred->stackDepth()) as a pseudo-comment.
Attachment #703639 - Flags: review?(sstangl) → review+

Comment 2

5 years ago
(In reply to Luke Wagner [:luke] from comment #0)
> Created attachment 703639 [details] [diff] [review]
> patch
> 
> It seems more direct to iterate over phisBegin()/phisEnd() directly.  This
> is good for OdinMonkey, which never creates resume points.

For those following at home, can you explain what OdinMonkey is or point to some information about it?
(Assignee)

Comment 3

5 years ago
Sure, it is an experimental implementation of asm.js, as specified by: https://github.com/dherman/asm.js/blob/master/tex/def.pdf.  Currently it is a patch queue at http://hg.mozilla.org/users/lwagner_mozilla.com/inbound-patches.

Comment 4

5 years ago
Cool, thanks for the info and best of luck in your implementation!
https://hg.mozilla.org/mozilla-central/rev/dcf3f2446544
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.