Closed
Bug 832070
Opened 11 years ago
Closed 11 years ago
IonMonkey: LTruncateDToInt32 doesn't need a snapshot
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
1.06 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
AFAICS
Attachment #703643 -
Flags: review?(sstangl)
Comment 1•11 years ago
|
||
Comment on attachment 703643 [details] [diff] [review] rm Review of attachment 703643 [details] [diff] [review]: ----------------------------------------------------------------- Yes indeed. Most likely some legacy thing. It's easy to accidentally leave extraneous snapshots all over the place, since the code is so spread out and no alarms sound. That whole path looks wonky, though: most of visitOutOfLineTruncate() should be in the inline path, with only the failure callWithABI() stuff in the out-of-line path. Both of the above should probably be the subject of new bugs..
Attachment #703643 -
Flags: review?(sstangl) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f5f3b2602e5
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3f5f3b2602e5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•