Closed Bug 832094 Opened 8 years ago Closed 8 years ago

make the top-level function ParseNode always be a PNK_FUNCTION

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Right now, it is a PNK_NAME for the top-level function node of a Function-constructor-compiled function.  This is useful if one wants to unconditionally go from a top-level function node to its funbox.
Attachment #703672 - Flags: review?(jorendorff)
Attached patch patchSplinter Review
Oops, forgot to qref.
Attachment #703672 - Attachment is obsolete: true
Attachment #703672 - Flags: review?(jorendorff)
Attachment #703674 - Flags: review?(jorendorff)
Comment on attachment 703674 [details] [diff] [review]
patch

Review of attachment 703674 [details] [diff] [review]:
-----------------------------------------------------------------

By all means.
Attachment #703674 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/2674257f6117
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.