832159 - Move internal part of InputData (nsEvent conversion) out from the header

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Oleg Romashin (:romaxa)]

I'm trying to reuse as much as possible from existing gecko code for embedding API.
and one thing required in order to make generic C++ embedding interface is ability to convert platform toolkit events into gecko events (InputData events)

basically I want to be able to use InputData outside of internal build and outside of XPCOM context (embed parent context), but in order to do that I need to move some functionality like 
MultiTouchInput(const nsTouchEvent& aTouchEvent)
MultiTouchInput(const nsMouseEvent& aMouseEvent)

into internal InputData.cpp file, so I can include header. for InputEvent intialization outside of Internal context...

I tried to initialize nsEvent's nsTouchEvents directly but as soon I create nsDOMTouchEvent outside of XPCOM context assert on garbage collector...

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Allow to use InputData.h outside of Internal build

Also I need default constructors in order to be able to IPC these events through IPDL.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

( Not garbage collector, but cycle collector, I guess.
nsEvent has strong refs to event targets, which are cycle collectable objects, so it should not
be uses off-main-thread. )

Comment 3

[Oleg Romashin (:romaxa)]

yep, that is why I guess it make sense to expose from embedding API InputData API, so touch event could be initialized like here:
https://github.com/tmeshkova/mozilla-central/blob/embedlite/embedding/embedlite/tests/qt/qtwidget/qgraphicsmozview.cpp#L465
pushed across IPDL into child gecko main thread
https://github.com/tmeshkova/mozilla-central/blob/embedlite/embedding/embedlite/PEmbedLiteView.ipdl#L48
 and then converted into nsEvent...
https://github.com/tmeshkova/mozilla-central/blob/embedlite/embedding/embedlite/utils/TabChildHelper.cpp#L615

Comment 4

[Doug Sherk (:drs) (inactive)]

What is the reason for adding ctors that take no parameters?

Comment 5

[Oleg Romashin (:romaxa)]

See Comment #1
IPDL generated code has initialization with default ctor...
see for example this commit where default ctor's were added to nsEvent
http://hg.mozilla.org/mozilla-central/rev/fb5ad0e555fd

Comment 6

[Doug Sherk (:drs) (inactive)]

Comment on attachment 703758 [details] [diff] [review]
Allow to use InputData.h outside of Internal build

Review of attachment 703758 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, I see. This code is actually smaug's baby though, so we should see what he says.

Also, is this patch formatted correctly? The review tool doesn't seem to be parsing InputData.cpp as a different file.

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Allow to use InputData.h outside of Internal build, and push throug IPDL

Formatted patch, change 2 space indent

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 704359 [details] [diff] [review]
Allow to use InputData.h outside of Internal build, and push throug IPDL

Don't have comments of a method in two places. I'd prefer keeping them in .h
I'm talking about the comment just before MultiTouchInput::MultiTouchInput(const nsMouseEvent& aMouseEvent)

Comment 9

[Oleg Romashin (:romaxa)]

https://tbpl.mozilla.org/?tree=Try&rev=da28d6bafd71
use this patch
https://hg.mozilla.org/try/raw-rev/ff910ca4ee9c

for checking

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa079b50b20

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ffa079b50b20