83220 - MFCEmbed "flashes" between page loads

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[David Hyatt]

I discovered that I caused this, and I have a patch that fixes it.  It's
trivial.  I just need to move the CheckForFocus call out of InitialReflow
and into the paint unsuppression routine.

This will also address jgaunt's hidden window issues, since by the time I do 
the check now, the widget will have been shown.

Comment 1

[David Hyatt]

Ok, I have r=saari, I just need an sr.

Comment 2

[David Hyatt]

Targeting at 0.9.1.  This is a very obvious visual defect whose fix is safe and 
trivial.

Comment 3

[Chris Waterson]

patch?

Comment 4

[chris hofmann]

does it show up in builds that some of our embedding friends make?

Comment 5

[lchiang]

the summary reflected that this shows up in mfcEmbed.  Hard to tell if it shows
up in embedding builds besides mfcEmbed since we are lacking builds at this point.

Comment 6

[Scott Collins]

Hyatt showed me on his machine his change to fix this moving one line from one
of a pair of routines always called together to the other.  We discussed, and he
avered that in no situation could the moved function call somehow be missed in
this new pattern.  He couldn't attach a patch at that moment because of other
changes in his tree.  He _will_ attach a patch, however, moving that one line,
and fixing a old-style cast nearby.  When he does, that patch is sr=scc.

Comment 7

[David Hyatt]

Attachment: Patch to move CheckForFocus call.

Comment 8

[David Hyatt]

I'm sure this would show up in any Windows embedding client.

Comment 9

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.1

Comment 10

[David Hyatt]

Fixed.