MFCEmbed "flashes" between page loads

RESOLVED FIXED in mozilla0.9.2

Status

()

Core
Document Navigation
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: David Hyatt, Assigned: David Hyatt)

Tracking

Trunk
mozilla0.9.2
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: have r=, sr=, a=)

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
I discovered that I caused this, and I have a patch that fixes it.  It's
trivial.  I just need to move the CheckForFocus call out of InitialReflow
and into the paint unsuppression routine.

This will also address jgaunt's hidden window issues, since by the time I do 
the check now, the widget will have been shown.
(Assignee)

Comment 1

17 years ago
Ok, I have r=saari, I just need an sr.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

17 years ago
Targeting at 0.9.1.  This is a very obvious visual defect whose fix is safe and 
trivial.
Target Milestone: --- → mozilla0.9.1
(Assignee)

Updated

17 years ago
OS: Windows 2000 → All

Comment 3

17 years ago
patch?

Comment 4

17 years ago
does it show up in builds that some of our embedding friends make?

Comment 5

17 years ago
the summary reflected that this shows up in mfcEmbed.  Hard to tell if it shows
up in embedding builds besides mfcEmbed since we are lacking builds at this point.
QA Contact: adamlock → bmartin

Comment 6

17 years ago
Hyatt showed me on his machine his change to fix this moving one line from one
of a pair of routines always called together to the other.  We discussed, and he
avered that in no situation could the moved function call somehow be missed in
this new pattern.  He couldn't attach a patch at that moment because of other
changes in his tree.  He _will_ attach a patch, however, moving that one line,
and fixing a old-style cast nearby.  When he does, that patch is sr=scc.

Updated

17 years ago
Blocks: 81668
(Assignee)

Comment 7

17 years ago
Created attachment 36609 [details] [diff] [review]
Patch to move CheckForFocus call.
(Assignee)

Comment 8

17 years ago
I'm sure this would show up in any Windows embedding client.

Comment 9

17 years ago
a= asa@mozilla.org for checkin to 0.9.1

Updated

17 years ago
Whiteboard: have r=, sr=, a=
(Assignee)

Comment 10

17 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla0.9.1 → mozilla0.9.2
You need to log in before you can comment on or make changes to this bug.