Closed Bug 832232 Opened 7 years ago Closed 7 years ago

crash in nsGeolocationService::SetHigherAccuracy


(Firefox OS Graveyard :: General, defect, critical)

Gonk (Firefox OS)
Not set


(blocking-b2g:tef+, firefox20 wontfix, firefox21 wontfix, firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

B2G C4 (2jan on)
blocking-b2g tef+
Tracking Status
firefox20 --- wontfix
firefox21 --- wontfix
firefox22 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed


(Reporter: scoobidiver, Assigned: jdm)


(Keywords: crash, Whiteboard: [b2g-crash])

Crash Data


(1 file, 1 obsolete file)

It's #15 crasher in B2G 18.0.

Frame 	Module 	Signature 	Source
0 	nsGeolocationService::SetHigherAccuracy 	nsGeolocation.cpp:1013
1 	mozilla::dom::ContentParent::RecvSetGeolocationHigherAccuracy 	ContentParent.cpp:2245
2 	mozilla::dom::PContentParent::OnMessageReceived 	PContentParent.cpp:1633
3 	mozilla::ipc::AsyncChannel::OnDispatchMessage 	AsyncChannel.cpp:473
4 	mozilla::ipc::RPCChannel::OnMaybeDequeueOne 	RPCChannel.cpp:402
5 	RunnableMethod<IPC::ChannelProxy::Context, void , Tuple0>::Run 	tuple.h:383
6 	mozilla::ipc::RPCChannel::DequeueTask::Run 	RPCChannel.h:425
7 	MessageLoop::RunTask
8 	MessageLoop::DeferOrRunPendingTask
9 	MessageLoop::DoWork
10 	mozilla::ipc::DoWorkRunnable::Run 	MessagePump.cpp:42
11 	nsThread::ProcessNextEvent 	nsThread.cpp:620
12 	NS_ProcessPendingEvents_P 	nsThreadUtils.cpp:187
13 	mozilla::dom::indexedDB::TransactionThreadPool::Cleanup 	TransactionThreadPool.cpp:165
14 	mozilla::dom::indexedDB::TransactionThreadPool::Shutdown 	TransactionThreadPool.cpp:121
15 	mozilla::dom::indexedDB::IndexedDatabaseManager::Observe 	IndexedDatabaseManager.cpp:1646
16 	nsObserverList::NotifyObservers 	nsObserverList.cpp:99
17 	nsObserverService::NotifyObservers 	nsObserverService.cpp:149
18 	mozilla::dom::power::PowerManagerService::SyncProfile 	PowerManagerService.cpp:110
19 	mozilla::dom::power::PowerManagerService::Reboot 	PowerManagerService.cpp:119
20 	mozilla::dom::power::PowerManager::Reboot 	PowerManager.cpp:68
21 	NS_InvokeByIndex_P 	xptcinvoke_arm.cpp:160
22 	XPCWrappedNative::CallMethod 	XPCWrappedNative.cpp:3083
23 	XPC_WN_CallMethod 	XPCWrappedNativeJSOps.cpp:1469
24 	js::InvokeKernel 	jscntxtinlines.h:364

More reports at:
Let's re-nom for blocking if we can find a reliable STR.
blocking-b2g: tef? → -
It still occurs in a recent build.
To whoever investigates this - I did end up seeing this after using the maps app and I think restarting the phone once. Might dig into this if I get more time.
My guess is :

It looks like the phone was restarted or turned off during the time that there was some high accuracy calls to the geolocation ?

I still can't seem to replicate though.
This crash is still occurring... looks like turning off or rebooting will make it occur.  Need to figure out timing.

service is probably garbage because we are shutting down?  jdm, you want to crack this?
Assignee: nobody → josh
Yeah, this should be a simple null-check.
not so sure.  if the service was null, wouldn't the crash be on:


but it is really on


It is as if the service object is deleted and non-null, doesn't it?
It's a crash at 0x1c, at the first usage of a member variable in the function. That smells like a NPE to me.
Attachment #715753 - Flags: review?(doug.turner)
Comment on attachment 715753 [details] [diff] [review]
Protect against missing geolocation services during shutdown.

nice try. ;)
Attachment #715753 - Flags: review?(doug.turner) → review-
Attachment #715753 - Attachment is obsolete: true
Attachment #715871 - Flags: review?(doug.turner) → review+
Closed: 7 years ago
Resolution: --- → FIXED
Can we get an uplift for this?  It's a null check.
blocking-b2g: - → shira?
I can't seem to get STRs to repro this.  I even went so far as to try to do a adb reboot as soon as I tried to load
Keywords: qawanted
naoki, if you can't get str, the way to verify this is to watch crash-stats and see if there is a significant change -- that is, we shouldn't see this crash any longer.

+1 on the uplift request.
tef? is probably what you are looking for if it's an uplift
blocking-b2g: shira? → tef?
Let's get this uplifted asap and watch the crash stats since we don't have STR.
blocking-b2g: tef? → tef+
tracking-b2g18: ? → ---
Keywords: steps-wanted
does not make sense to create a regression issue.
Flags: in-moztrap-
Verified fixed on 
Unagi Build ID: 20130403070201
Kernel Date: Dec 5
Gaia: daea430624ec02f8d36a12d581fc4a3278c27cb7


Unagi Build ID: 20130403070204
Kernel Date: Dec 5
Gaia: 06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75

No Crash occurs in nsGeolocationService. Does not Repro.
You need to log in before you can comment on or make changes to this bug.