Please report any other irregularities here.
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8592c41069c2&tochange=1761f4a9081c Bug 828509? Bug 829198?
Keywords: regression, reproducible
tracking-fennec: --- → ?
status-firefox21: --- → affected
This is from bug 829198. I'm sick of chasing these listview color problems. I'm going to flip us to Holo_light and fixup all the problems that causes.
Created attachment 705138 [details] [diff] [review] Patch v1 Moves us to using a light theme throughout. There are a few pieces to this, and it will need bake time... 1.) Doorhangers are using android.R.attr.textColorPrimary even though we have a custom backgrond behind them. This is an easy fix. We shouldn't be using system colors in this case. Autocomplete items have the same problem (custom background using system text colors). I removed both. 2.) The site settings dialog uses custom everything. I made the rows inherit from our normal listitem style so that they have the correct textColor. They override the style's textAppearance to alter their size. This also brought out some bugs in this dialog using v14+ colors and text sizes. I just reverted them to use item height support on earlier versions of Android. Looks fine. 3.) Site settings dialog titlebar. These dialogs aren't actually "light" on pre GB, but for some reason they use a light titlebar text color (black on black?). I can't find a great fix for this (their are system styles but they don't specify a textColor), so I hard coded two different colors (white for pre GB and holo_blue for post).
Attachment #705138 - Flags: review?
Attachment #705138 - Flags: review? → review?(sriram)
Comment on attachment 705138 [details] [diff] [review] Patch v1 Review of attachment 705138 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. I couldn't see any possible regressions as all the textColorPrimary's are replaced with a solid color. Please watch out for any regression that might come up.
Attachment #705138 - Flags: review?(sriram) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Verified fixed on Samsung Galaxy R (Android 2.3.4)/ Nightly 21.0a1(2013-01-27)
Status: RESOLVED → VERIFIED
Fixed on Huawei U8651 (T-Mobile Prism) Android 2.3.6 Nightly 21.0a1 (2013-01-27). This is an ARMv6 device.
You need to log in before you can comment on or make changes to this bug.