Closed Bug 832352 Opened 7 years ago Closed 7 years ago

make sure all mozconfigs include the common ones

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(3 files)

I just had occasion (bug 823989 comment 44) to make use of the common mozconfigs added in bug 738612.  I decided to audit the mozconfigs in browser/config/mozconfigs/ to make sure these all included them as I expected.  That audit was somewhat quick, but yielded this list of things that are wrong:
 * win64 builds didn't include mozconfig.common
 * asan builds didn't include mozconfig.common
 * valgrind builds did other things after including mozconfig.common.override

I believe this patch fixes those; it is however completely untested.
Attachment #703930 - Flags: review?(ted) → review+
Attachment #703930 - Attachment description: Make sure all mozconfigs include build/mozconfig.common and that they all include build/mozconfig.common.override last. → patch 1: Make sure all browser mozconfigs include build/mozconfig.common and that they all include build/mozconfig.common.override last.
Attachment #704186 - Flags: review?(ted) → review+
Attachment #704185 - Flags: review?(ted) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.