832412 - Location permissions screen overlays screen until an option is selected

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tyler Downer [He/Him]]

Open up Camera app, Location permission screen appears. Press home button. Camera app go away, but location permission page won't until you select an option. The permission screen should go away with the home button press.

Comment 1

[Dietrich Ayala (:dietrich)]

Should go away when app goes away.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The bug is way less visible those days since the platform checks for the visibility of the app before sending a prompt message. Sadly the visibility of the app is changed at a good time for screenshot but a bad time for this when the user hit the home button. As a result the bug still happens if you open the camera app, wait for 1 second and a half and then hit the home button. Timing is important to reproduce it now.

I'm going to add a new API to monitor the visibility of the mozbrowser element in order to fire an event to cancel the request if needed. I don't see any other proper way.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Gecko Part - wip

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Gecko patch

Etienne since you played with visibility the last time I'm asking you the review for both the Gecko and Gaia part.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Gaia part

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 751114 [details] [diff] [review]
Gecko patch

Review of attachment 751114 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nits addressed

::: b2g/components/ContentPermissionPrompt.js
@@ +161,5 @@
> +      // away but the request is still here.
> +      frame.addEventListener("mozbrowservisibilitychange", onVisibilityChange);
> +
> +      self.delegatePrompt(request, requestId, function onCallback() {
> +        frame.addEventListener("mozbrowservisibilitychange", onVisibilityChange);

adding it twice?

@@ +167,3 @@
>      };
> +
> +    // Something went wront. Let's cancel the request just in case.

s/wront/wrong

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/projects/birch/rev/b95ac4ad8039

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/95bd09ced75d3b9b7b857464932a942fdf971902

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b95ac4ad8039

Comment 10

[Darren]

Created a test case for checking when using the home button ends the prompt until going back into the app.

https://moztrap.mozilla.org/manage/cases/?filter-id=9253