832419 - Clean up IPC blobs

Status: RESOLVED FIXED

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Created attachment 703995 [details] [diff] [review]
Patch, v1

This is the approach that khuey and I discussed at the B2G work week that simplifies the existing code (from bug 806503) quite a bit. All the tests look good and try server was happy last week (running again now just to make sure). I really don't want this patch to rot so let's get it in soon.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Try looks happy still.

https://tbpl.mozilla.org/?tree=Try&rev=2f547e8b2040

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Created attachment 710118 [details] [diff] [review]
Original patch (sorta)

This is the original patch but hg merge troubles have made it a little strange. I'll point out the non-relevant bits.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 710118 [details] [diff] [review]
Original patch (sorta)

Review of attachment 710118 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentChild.cpp
@@ +607,5 @@
>      // yet since that may stat a file on the main thread
>      // here. Instead we'll learn the size lazily from the
>      // other process.
> +    params.blobParams() = MysteryBlobConstructorParams();
> +    params.optionalInputStreamParams() = void_t();

I think we should remove support for sending mystery blobs from child to parent. Followup bug though.

::: dom/ipc/PContent.ipdl
@@ +144,5 @@
>  {
>    // Nothing is known about this type of blob.
>  };
>  
> +union ChildBlobConstructorParams

I'll just whine a bit about how this name is all wrong and how we should use something better. But I can't think of a better name.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88c2a0a35a65

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88c2a0a35a65

Comment 6

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi bent, 
Does this patch would affect my patch? 
Bug 834165 - Implement BlobEvent

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Randy Lin [:rlin] from comment #6)
> Does this patch would affect my patch?

I don't think so.