Closed
Bug 832419
Opened 10 years ago
Closed 10 years ago
Clean up IPC blobs
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
Details
Attachments
(2 files)
64.94 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
28.50 KB,
patch
|
Details | Diff | Splinter Review |
This is the approach that khuey and I discussed at the B2G work week that simplifies the existing code (from bug 806503) quite a bit. All the tests look good and try server was happy last week (running again now just to make sure). I really don't want this patch to rot so let's get it in soon.
Attachment #703995 -
Flags: review?(jonas)
Assignee | ||
Comment 1•10 years ago
|
||
Try looks happy still. https://tbpl.mozilla.org/?tree=Try&rev=2f547e8b2040
Assignee | ||
Comment 2•10 years ago
|
||
This is the original patch but hg merge troubles have made it a little strange. I'll point out the non-relevant bits.
Comment on attachment 710118 [details] [diff] [review] Original patch (sorta) Review of attachment 710118 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/ipc/ContentChild.cpp @@ +607,5 @@ > // yet since that may stat a file on the main thread > // here. Instead we'll learn the size lazily from the > // other process. > + params.blobParams() = MysteryBlobConstructorParams(); > + params.optionalInputStreamParams() = void_t(); I think we should remove support for sending mystery blobs from child to parent. Followup bug though. ::: dom/ipc/PContent.ipdl @@ +144,5 @@ > { > // Nothing is known about this type of blob. > }; > > +union ChildBlobConstructorParams I'll just whine a bit about how this name is all wrong and how we should use something better. But I can't think of a better name.
Attachment #703995 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/88c2a0a35a65
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/88c2a0a35a65
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 6•10 years ago
|
||
Hi bent, Does this patch would affect my patch? Bug 834165 - Implement BlobEvent
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Randy Lin [:rlin] from comment #6) > Does this patch would affect my patch? I don't think so.
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•