832463 - rename balrog-client.py (and associated bits) to balrog-submitter.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

...because "client" is a term already used in talking about a Firefox or other application that queries for an update.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: rename balrog client

I've put in a symlink to the old name for now to avoid any failures while we switch over.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: use new name

Comment 3

[[e-mail] (:bhearsum)]

Just realized that Windows will probably fail because it doesn't support symlinks. It'll be fixed once the buildbotcustom patch is in production.

Comment 4

[[e-mail] (:bhearsum)]

To my surprise this didn't even work for Linux. The buildbotcustom patch is headed to production today though, so meh.

Comment 5

[[e-mail] (:bhearsum)]

I missed an import:
Traceback (most recent call last):
  File "/builds/slave/m-cen-lx-l10n-ntly-00000000000/tools/scripts/updates/balrog-submitter.py", line 11, in <module>
    from balrog.submitter.cli import NightlyRunner
  File "/builds/slave/m-cen-lx-l10n-ntly-00000000000/tools/lib/python/balrog/submitter/cli.py", line 7, in <module>
    from balrog.client.api import SingleLocale
ImportError: No module named client.api

I landed a bustage fix in https://hg.mozilla.org/build/tools/rev/7a8342a33cc2. Things are all good now.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Woot!