Closed Bug 832473 Opened 7 years ago Closed 7 years ago

Variables View: empty variable is rendered wrongly if it is added within scope with label

Categories

(DevTools :: Debugger, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 21

People

(Reporter: msucan, Assigned: vporof)

References

Details

Attachments

(1 file)

If I do addScope("foo").addVar().addProperties(props) I get the scope header correctly rendered, but the variable is rendered as ": undefined". The variable should continue to be hidden.
Tried:

let scope = view.addScope("foo");
scope.expanded = true;
scope.locked = true;

// I needed a getter and setter for |locked|. I added in my patch

Then the usuals... addVar() and addProperties(props).

Now initial rendering is correct. However, if I click the header title the empty var shows up (": undefined"). Nothing else changes. Weird.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P1
Attached patch v1Splinter Review
Attachment #704935 - Flags: review?(mihai.sucan)
Comment on attachment 704935 [details] [diff] [review]
v1

Thank you! This works fine for me.
Attachment #704935 - Flags: review?(mihai.sucan) → review+
https://hg.mozilla.org/mozilla-central/rev/4b7c0bb2dd04
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.