832474 - nsDeleteDir initializes timer off the main thread

Status: RESOLVED WONTFIX

(Core :: Networking: Cache, defect)

Description

[Michal Novotny [:michal]]

Timer in nsDeleteDir::PostTimer() is often initialized off the main thread which is not allowed according to http://mxr.mozilla.org/mozilla-central/source/xpcom/threads/nsITimer.idl#56

Comment 1

[Honza Bambas (:mayhemer)]

Just let you know that there is bug to make this thread safe (not sure about the number right now, ask Jason).

Comment 2

[Honza Bambas (:mayhemer)]

I mean to make starting the timer safe off the main thread, not fixing nsDeleteDir.

Comment 3

[Jason Duell]

INVALID now that off thread use is safe

Comment 4

[Michal Novotny [:michal]]

Reopening since we initialize and cancel the timer on a different thread.

Comment 5

[Patrick McManus [:mcmanus]]

is this still a concern?

Comment 6

[Honza Bambas (:mayhemer)]

(In reply to Patrick McManus [:mcmanus] from comment #5)
> is this still a concern?

I don't think this (in browser) is a problem with the default config.

The timer is multithreaded only partially.  But I'd rather fix the timer than the old cache code.

Comment 7

[Michal Novotny [:michal]]

I don't remember exactly what is the problem with initializing and canceling timer on different thread. If the worst what can happen is that the timer is run even if Cancel() was called then it's IMO not worth fixing this bug. We use nsDeleteDir in the new cache only to delete the inactive cache if it exists and this code should go away one day together with the old cache.