Closed Bug 832553 Opened 8 years ago Closed 8 years ago

Use 2x close button icons in sidebars in HiDPI mode

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: fryn, Unassigned)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
It seems that we have a special close-sidebar.png that looks exactly the same as close.png, except for a hardly noticeable difference in lightness in the non-hover/non-active state. We only do this in pinstripe and not winstripe or gnomestripe.

I propose we simply use close.png and close@2x.png for sidebar close buttons and remove close-sidebar.png from the tree.
Attachment #704145 - Flags: review?(shorlander)
Comment on attachment 704145 [details] [diff] [review]
patch

Review of attachment 704145 [details] [diff] [review]:
-----------------------------------------------------------------

These sidebar close button is actually tinted blue to mesh with the sidebar colors. You can see it more clearly here: http://cl.ly/image/0H1u191L0U3t

I would rather keep it and just update it to 2x.
Attachment #704145 - Flags: review?(shorlander) → review-
Ah, I see.
Assignee: fyan → nobody
No longer blocks: 795665
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.