832567 - Video/AudioConduit code doesn't enable RTCP reception

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

This is why even with bug 831831 fixed, we still don't recover from errors.  StartReceive() must be called in order to process incoming RTCP packets.

For minimizing risk, turned off NACK processing as some of the logs implied they were forcing extra keyframe requests.  We may turn it back on later.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WebRTC RTP code needs StartReceive() called to process RTCP packets

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 704165 [details] [diff] [review]
WebRTC RTP code needs StartReceive() called to process RTCP packets

I'll take a review from anyone.  Bueller?

Yes, I'll correct the spelling error in the debug....

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

FYI, tested it with a 1-in-500 packet drop inserted; errors appear and are wiped away instantly.

STATEINFO ; (21: 8:43: 44 |    0)     RTP/RTCP:    5     0;     26890; SIG [RTCP] Incoming PLI from SSRC:0x52cf8a3
STATEINFO ; (21: 8:43: 44 |    0)        VIDEO:    5     0;     26890; OnReceivedIntraFrameRequest

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://tbpl.mozilla.org/?tree=Try&rev=8038ee63c8bf

Flo, JB, Mark - please give this a try

Comment 5

[Eric Rescorla (:ekr)]

Comment on attachment 704165 [details] [diff] [review]
WebRTC RTP code needs StartReceive() called to process RTCP packets

Review of attachment 704165 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm though i'm a little worried that this will cause the conduit to emit rtcp messages.

Wonder if we should put in a MOZ_ASSERT(mEngineReceiving); in SendRTCPPacket? or at least a log.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: transmitting-only channels weren't accepting RTCP; turn off NACK mode and block bad outgoing RTCP from transmit-only channels

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 704182 [details] [diff] [review]
transmitting-only channels weren't accepting RTCP; turn off NACK mode and block bad outgoing RTCP from transmit-only channels

Better fix; original StartReceive works but starts up a decoder thread we don't need.

Pushed a try as well https://tbpl.mozilla.org/?tree=Try&rev=fb99a3c1effc

Comment 8

[Eric Rescorla (:ekr)]

Comment on attachment 704182 [details] [diff] [review]
transmitting-only channels weren't accepting RTCP; turn off NACK mode and block bad outgoing RTCP from transmit-only channels

Review of attachment 704182 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35b633fb9fbc
and adjust min bitrate to 200Kbps (rs=me)
https://hg.mozilla.org/integration/mozilla-inbound/rev/422d79422232

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/35b633fb9fbc
https://hg.mozilla.org/mozilla-central/rev/422d79422232