Closed Bug 832567 Opened 9 years ago Closed 9 years ago

Video/AudioConduit code doesn't enable RTCP reception

Categories

(Core :: WebRTC: Networking, defect)

17 Branch
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Whiteboard: [webrtc][blocking-webrtc+][qa-])

Attachments

(1 file, 1 obsolete file)

This is why even with bug 831831 fixed, we still don't recover from errors.  StartReceive() must be called in order to process incoming RTCP packets.

For minimizing risk, turned off NACK processing as some of the logs implied they were forcing extra keyframe requests.  We may turn it back on later.
Depends on: 831831
Comment on attachment 704165 [details] [diff] [review]
WebRTC RTP code needs StartReceive() called to process RTCP packets

I'll take a review from anyone.  Bueller?

Yes, I'll correct the spelling error in the debug....
Attachment #704165 - Flags: review?(tterribe)
Attachment #704165 - Flags: review?(ekr)
FYI, tested it with a 1-in-500 packet drop inserted; errors appear and are wiped away instantly.

STATEINFO ; (21: 8:43: 44 |    0)     RTP/RTCP:    5     0;     26890; SIG [RTCP] Incoming PLI from SSRC:0x52cf8a3
STATEINFO ; (21: 8:43: 44 |    0)        VIDEO:    5     0;     26890; OnReceivedIntraFrameRequest
https://tbpl.mozilla.org/?tree=Try&rev=8038ee63c8bf

Flo, JB, Mark - please give this a try
Comment on attachment 704165 [details] [diff] [review]
WebRTC RTP code needs StartReceive() called to process RTCP packets

Review of attachment 704165 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm though i'm a little worried that this will cause the conduit to emit rtcp messages.

Wonder if we should put in a MOZ_ASSERT(mEngineReceiving); in SendRTCPPacket? or at least a log.
Attachment #704165 - Flags: review?(ekr) → review+
Attachment #704165 - Attachment is obsolete: true
Attachment #704165 - Flags: review?(tterribe)
Comment on attachment 704182 [details] [diff] [review]
transmitting-only channels weren't accepting RTCP; turn off NACK mode and block bad outgoing RTCP from transmit-only channels

Better fix; original StartReceive works but starts up a decoder thread we don't need.

Pushed a try as well https://tbpl.mozilla.org/?tree=Try&rev=fb99a3c1effc
Attachment #704182 - Flags: review?(tterribe)
Attachment #704182 - Flags: review?(ekr)
Comment on attachment 704182 [details] [diff] [review]
transmitting-only channels weren't accepting RTCP; turn off NACK mode and block bad outgoing RTCP from transmit-only channels

Review of attachment 704182 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #704182 - Flags: review?(ekr) → review+
Blocks: 832683
Attachment #704182 - Flags: review?(tterribe)
Whiteboard: [webrtc][blocking-webrtc+][webrtc-uplift] → [webrtc][blocking-webrtc+][webrtc-uplift][qa-]
Whiteboard: [webrtc][blocking-webrtc+][webrtc-uplift][qa-] → [webrtc][blocking-webrtc+][qa-]
No longer depends on: webrtc_upstream_bugs
No longer blocks: webrtc_upstream_bugs
You need to log in before you can comment on or make changes to this bug.