832617 - evaluate reducing queries load by passing frecency to visit observers

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

onItemVisited has to re-read node info from the database to properly update frecency cause the notification doesn't give this data.
We may also evaluating if onVisit may want that.
Though if this means adding another read query to History.cpp to read the new frecency value it may not be worth it (could be we already do though, so that'd be free)

Comment 1

[Emma Benoit]

Attachment: Fix folding library to libnss3, tests on libnss3 and libnspr4

Can someone confirm that ctypes.int is the right type to use for a function returning a SECStatus ?

I'm confused by the function to use for libnspr4: the documentation don't say clearly if it's PL_strcpy
or PR_strcpy. I tried both, but none seems to be exported in nspr4.