832628 - Follow symlinks when building addons

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

See https://github.com/mozilla/addon-sdk/pull/715 for more information.

Basically we don't follow symlinks when building addons and we should.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/731

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 704375 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/731

Mossop can you test this on Windows for me when you have a chance?

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Just need to run `cfx testaddons`

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 704375 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/731

Testing symlink...
ModuleNotFoundError: unable to satisfy: require(extra/extra) from
  C:\Users\Alex\Desktop\mozilla\jetpack\test\addons\symlink\lib\main.js:12:
Looked for it in:
  C:\Users\Alex\Desktop\mozilla\jetpack\test\addons\symlink\lib\extra\extra.js
  C:\Users\Alex\Desktop\mozilla\jetpack\lib\extra\extra.js
  C:\Users\Alex\Desktop\mozilla\jetpack\test\addons\symlink\lib\extra\extra.js

Testing symlink-data-folder...
Using binary at 'C:\Program Files (x86)\Mozilla Firefox\firefox.exe'.
Using profile at 'c:\users\alex\appdata\local\temp\tmptev0pe.mozrunner'.
Running tests on Firefox 18.0.1/Gecko 18.0.1 ({ec8030f7-c20a-464f-9b0e-13a3a9e97
384}) under winnt/x86-msvc.
error: symlink-data-folder: An exception occurred.
NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_F
ILE_NOT_FOUND) [nsIChannel.open]
undefined 109
Traceback (most recent call last):
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/timers
.js", line 31, in notify
    callback.apply(null, args);
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/test/r
unner.js", line 48, in null
    onDone: onDone
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/test/h
arness.js", line 444, in runTests
    nextIteration();
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/test/h
arness.js", line 273, in nextIteration
    findAndRunTests(loader, nextIteration);
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/test/r
unner.js", line 127, in findAndRunTests
    onDone: nextIteration
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/deprec
ated/unit-test.js", line 443, in startMany
    runNextTest(this);
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/deprec
ated/unit-test.js", line 438, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/deprec
ated/unit-test.js", line 469, in start
    this.test.testFunction(this);
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/test.j
s", line 72, in null
    test(assert);
  File "resource://symliink-at-test-dot-mozilla-dot-com/symlink-data-folder/lib/
main.js", line 9, in null
    assert.equal(data.load('index.html'), 'SYMLINK TEST DATA');
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/self.j
s", line 39, in read
    return readURISync(uri(path));
  File "resource://symliink-at-test-dot-mozilla-dot-com/addon-sdk/lib/sdk/net/ur
l.js", line 109, in readURISync
    let stream = channel.open();

0 of 1 tests passed.

Comment 5

[Alexandre Poirot [:ochameau]]

It would be cool to write down a brief explanation on why this bug is wontfix, especially when people outside of the project are involved.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Sorry, meant to get back to this bug to comment, but triage moved faster than I could keep up.

Irakli could probably explain better than I, but we don't want to be adding features to python cfx that will be difficult or impossible to also implement in cfx-js.

Comment 7

[m.coenca]

Hello ! Still no plans on bringing this feature live ? 

(If not, any recommandation for people that are willing to build cross browser extensions with their own api, where symlinks would point to shared folders between extensions would be gladly appreciated : ) 

Thanks