Last Comment Bug 832666 - Remove on Win8 the fog on tabbar
: Remove on Win8 the fog on tabbar
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All Windows 8
: -- normal (vote)
: Thunderbird 22.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on: 816803
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-19 12:03 PST by Richard Marti (:Paenglab)
Modified: 2013-03-01 08:57 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (7.88 KB, patch)
2013-01-19 12:12 PST, Richard Marti (:Paenglab)
no flags Details | Diff | Review
patch v2 (7.94 KB, patch)
2013-01-27 04:44 PST, Richard Marti (:Paenglab)
mconley: review+
Details | Diff | Review

Description Richard Marti (:Paenglab) 2013-01-19 12:03:58 PST
Under Win8 the fog on tabbar for better readability on Glass is still shown. Also when Win8 doesn't use Glass.

Bug 816803 implements the -moz-windows-glass media query keyword which makes it possible to apply things only to Glass.
Comment 1 Richard Marti (:Paenglab) 2013-01-19 12:12:46 PST
Created attachment 704259 [details] [diff] [review]
patch

As bug 816803 has r+ it will be shortly checked-in. This patch makes applying the fog and the inverted icon on tabbar only on Glass.

Until bug 816803 is checked-in this patch needs applying the patch from this bug first.
Comment 2 Richard Marti (:Paenglab) 2013-01-27 04:44:42 PST
Created attachment 706863 [details] [diff] [review]
patch v2

Added comments and two missing braces on tabmail-aero.css.
Comment 3 Mike Conley (:mconley) - (Needinfo me!) 2013-02-28 16:44:07 PST
Comment on attachment 706863 [details] [diff] [review]
patch v2

Review of attachment 706863 [details] [diff] [review]:
-----------------------------------------------------------------

I'm so, so sorry for how long this has taken me. :/ Took some time to get a build up that would work in Windows 8.

Anyhow, I did, and this looks wonderful, as usual. Thanks Richard!
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-03-01 07:22:26 PST
https://hg.mozilla.org/comm-central/rev/cbfa7ed4926b

Note You need to log in before you can comment on or make changes to this bug.