832668 - Selection listeners only register on new tabs

Status: RESOLVED WORKSFORME

(Add-on SDK Graveyard :: General, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Based on this thread:

https://groups.google.com/forum/#!topic/mozilla-labs-jetpack/FRxcSSZEcjY

Repro: https://builder.addons.mozilla.org/package/170313/latest/

If I load that add-on, only tabs opened afterwards will trigger the selection event handler. This causes a slightly jarring difference in behavior depending on how the add-on is loaded, similar to how page-mod used to be.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Can you test this against stabilization or master? IIRC, the selection module rewrite in 1.13 fixed this.

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I think stabilization behaves better in most cases - I made the mistake of teesting using the builder editor which seems to behave oddly:

1. if you enable the add-on with builder loaded, selecting text in the builder editor produces 2-3x more events than usual ( for other text )

2. if you then reload the builder page with the add-on still active, you get no events at all.

I'm wondering if this is a secondary and much more obscure bug. ZER0?

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

1.13 resolves this.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Cool, I was wondering, in fact, if you tried to build an XPI with the latest master.

Let me know if there are other bugs similar to that, selection is a kind of a ugly beast to deal with!

Comment 5

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: xpi built with stabilization branch.

I built this with the 1.13 tag, and it exhibits the behavior I've been seeing previously.

Comment 6

[Matteo Ferretti [:zer0] [:matteo]]

Jeff, it works for me in `master`, but with 1.13 tag I have the same issue you mentioned yesterday in IRC. It seems that some fix landed in master months ago are not in 1.13. This one for instance:

https://github.com/mozilla/addon-sdk/commit/bf36170f13a10ad8f11802fbc35ddbf2abf82f3f

That I believe fixes the problem.