Closed Bug 832693 Opened 9 years ago Closed 9 years ago

Move protocol logic in about:telemetry into SymbolicationRequest

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: vladan, Assigned: espindola)

References

Details

Attachments

(1 file)

All the logic that deals with sending XMLHttpRequests to the Symbolication Server in the about:telemetry page should be in the SymbolicationRequest class.

Rafael requested this be a separate bug in https://bugzilla.mozilla.org/show_bug.cgi?id=831623#c4
Assignee: nobody → respindola
Attached patch patchSplinter Review
I tested this with late writes on a mac. The windows build is still going.
Attachment #709798 - Flags: review?(vdjeric)
Comment on attachment 709798 [details] [diff] [review]
patch

- If there is an exception in the "handleSymbolResponse" function, will it have a readable name printed in its stack trace or will it be shown as an anonymous function?
- handleSymbolResponse could use a comment header
- you don't want your late writes stacks to have pretty headers? ;)
Attachment #709798 - Flags: review?(vdjeric) → review+
The windows build finished and symbolication worked fine. I will checkin the patch since it fixes this bug and introduces no regressions. I will open followup bugs for these comments.

> - If there is an exception in the "handleSymbolResponse" function, will it
> have a readable name printed in its stack trace or will it be shown as an
> anonymous function?
> - handleSymbolResponse could use a comment header
> - you don't want your late writes stacks to have pretty headers? ;)
https://hg.mozilla.org/mozilla-central/rev/01836b9cdcf1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.