832693 - Move protocol logic in about:telemetry into SymbolicationRequest

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

All the logic that deals with sending XMLHttpRequests to the Symbolication Server in the about:telemetry page should be in the SymbolicationRequest class.

Rafael requested this be a separate bug in https://bugzilla.mozilla.org/show_bug.cgi?id=831623#c4

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

I tested this with late writes on a mac. The windows build is still going.

Comment 2

[Vladan Djeric (:vladan)]

Comment on attachment 709798 [details] [diff] [review]
patch

- If there is an exception in the "handleSymbolResponse" function, will it have a readable name printed in its stack trace or will it be shown as an anonymous function?
- handleSymbolResponse could use a comment header
- you don't want your late writes stacks to have pretty headers? ;)

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The windows build finished and symbolication worked fine. I will checkin the patch since it fixes this bug and introduces no regressions. I will open followup bugs for these comments.

> - If there is an exception in the "handleSymbolResponse" function, will it
> have a readable name printed in its stack trace or will it be shown as an
> anonymous function?
> - handleSymbolResponse could use a comment header
> - you don't want your late writes stacks to have pretty headers? ;)

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/01836b9cdcf1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01836b9cdcf1