832831 - Make NS_ASSERT_OWNINGTHREAD_AND_NOT_CCTHREAD fatal

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: make NS_ASSERT_OWNINGTHREAD_AND_NOT_CCTHREAD fatal

NS_ASSERT_OWNINGTHREAD is fatal since bug 753659.

NS_ASSERT_OWNINGTHREAD_AND_NOT_CCTHREAD seems like it should be, too. That catches the mistake of accidentally pasting a UNLINK macro in one class's TRAVERSE block.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 704413 [details] [diff] [review]
make NS_ASSERT_OWNINGTHREAD_AND_NOT_CCTHREAD fatal

Review of attachment 704413 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/nsISupportsImpl.h
@@ +66,5 @@
>    do { \
>      if (NS_IsCycleCollectorThread()) { \
>        NS_ERROR("Changing refcount of " #_class " object during Traverse is " \
>                 "not permitted!"); \
> +      NS_ABORT(); \

Why can't this just be

MOZ_NOT_REACHED("Changing refcount ...");

?

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: make NS_ASSERT_OWNINGTHREAD_AND_NOT_CCTHREAD fatal

> Why can't this just be
> 
> MOZ_NOT_REACHED("Changing refcount ...");
> 
> ?

Because... BECAUSE!

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/bdfca6aa9742

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bdfca6aa9742