832843 - [OPEN_] Entering a number in dialer and then adding to contact, it can not return to the contact after locked screen.(617001973065)

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Firefox_Mozilla]

Steps to reproduce:
1.go into dialer and enter some numbers;
2.tap the contact icon in dialer to add this number to contact;
3.when in eidt interface of contact, press the power key to lock the screen;
3.press the power key again to wake the screen and unlock it.

Actual results:
1.it returned to the dialer.

Expected results:
1.after unlocked the screen, it remain in edit interface of contact;

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: QAwanted to confirm symptom

Comment 2

[Al Tsai [:atsai]]

Confirmed in 20130126070202

Comment 3

[Jason Duell]

I'm still seeing this.

Comment 4

[alberto.pastor]

Removing all the activities when going to the lockscreen is something recently added by Bug 856692. See:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L1587

I would suggest just sending the event for hiding the keyboard but not killing the activity. Regarding the camera issue, I would kill the activity only when clicking on the "Camera" button on the lockscreen.

Anyway, I would like Vivien's opinion here. May be UX could give us opinion about the best option in terms of usability as well.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Alberto Pastor [:albertopq] from comment #4)
> Removing all the activities when going to the lockscreen is something
> recently added by Bug 856692. See:

That's not recent. We were doing that, killing the inline activity before. Now we hide the keyboard when killing an inline activity.

> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/
> window_manager.js#L1587
> 
> I would suggest just sending the event for hiding the keyboard but not
> killing the activity. Regarding the camera issue, I would kill the activity
> only when clicking on the "Camera" button on the lockscreen.

+1000 :)

> 
> Anyway, I would like Vivien's opinion here. May be UX could give us opinion
> about the best option in terms of usability as well.

Yep, also someone from UX to validate the assumption that we should stay on the activity after a lock screen.

Cheers!

Comment 6

[ayman maat :maat]

passing this to Jorge to look into.

Comment 7

[Jorge Juan P.]

I would suggest the following flow:
1.go into dialer and enter some numbers;
2.tap the contact icon in dialer to add this number to contact;
3.when in edit interface of contact, press the power key to lock the screen;
4.press the power key again to wake the screen;
     - if user unlocks screen {
	5.edit interface of contact is shown (with the data that she previously entered filled, if she did);
	}
     - if user taps on "Camera"{
	6. Camera activity begins;
	7. When user opens "Dialer", the keypad opens with the phone number already dialed on point 1.;
	}


Just to take it into account: when user is in point 3 (edit interface of contact):
- what happens if she entered some data ("Name", "Last name"...) but she didn´t save it?
- would we be able to save that info in some way?
- would it be desirable from a performance perspective?

Cheers!

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I don't think we should change the assumption made about inline activities. In the worst case the dialer app can do something magic since it is coupled with the dialer anyway.

More generally I would like to have more use cases to see if something needs to be changed globally for activities.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Any new about this, is something we can live with?

I think this just felt down from all of our priorities, is there any way we can mark bugs to be revisited or rethinking for versions post 1.1?

Looks to me as an use case to have into account if we decide to rethink the window manager and activities in future versions.

Cheers,
F.

Comment 10

[Johan Lorenzo [:jlorenzo]]

I'll check if I can still repro this one.

Comment 11

[Johan Lorenzo [:jlorenzo]]

Tested against:
Gaia-Rev        5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/688f821edcd4
Build-ID        20141112040208
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

After unlocking the screen, I'm still in the "create contact" page.