Closed Bug 832951 Opened 7 years ago Closed 7 years ago

[WebPayment] Expose DOMRequest ID within mozChromeEvents

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21
blocking-b2g tef+
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
firefox21 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- fixed

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

In order to fix Bug 832948 we need to expose the DOMRequest identifier within the mozChromeEvents that triggers the creation of the payment trusted dialogs.
Assignee: nobody → ferjmoreno
Blocks: 832948
blocking-b2g: --- → tef?
Attached patch v1Splinter Review
Attachment #704643 - Flags: review?(fabrice)
Comment on attachment 704643 [details] [diff] [review]
v1

Review of attachment 704643 [details] [diff] [review]:
-----------------------------------------------------------------

r=me - bonus points if you s/DOMRequestId/requestId
Attachment #704643 - Flags: review?(fabrice) → review+
Does that mean that the requestId is exposed to the content?
mozChromeEvents are only sent to the Gaia system app, so the requestId is exposed only to this app. If you consider it as normal web content, then yes, but no other application or web content would have access to this id (or any other data include within the mozChromeEvent).

Maybe the bug title is not the best ...
Triage is a bit puzzled on this one. Can this actually reproduce with our v1 requirements? We only have one payment flow for v1.

How would I reproduce this with our existing v1 constraints? Can you explain a bit more?
Flags: needinfo?(ferjmoreno)
https://hg.mozilla.org/mozilla-central/rev/23e803630aca
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
(In reply to Jason Smith [:jsmith] from comment #6)
> Triage is a bit puzzled on this one. Can this actually reproduce with our v1
> requirements? We only have one payment flow for v1.
> 
> How would I reproduce this with our existing v1 constraints? Can you explain
> a bit more?

This bug is also a dependency for bug 832948 so the same reply at https://bugzilla.mozilla.org/show_bug.cgi?id=832948#c8 applies here.
Flags: needinfo?(ferjmoreno)
Whiteboard: [qa-]
blocking-b2g: tef? → tef+
Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.
You need to log in before you can comment on or make changes to this bug.