832958 - Workers: Switch from AutoSafeJSContext to mozilla::SafeAutoJSContext

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect, P5)

Description

[Mounir Lamouri (:mounir)]

mozilla::SafeAutoJSContext has been introduced in bug 828472 and could be used instead of the AutoSafeJSContext defined in Workers code.

Comment 1

[Mounir Lamouri (:mounir)]

Looking at AutoSafeJSContext a bit more, I realise it's not really as trivial because AutoSafeJSContext can take a context in ctor parameter and will do push and pop. mozilla::AutoJSContext just returns a context. It will do push and pop if it is a safe context.

Comment 2

[Bobby Holley (:bholley)]

Yeah if it's nontrivial it's probably not a very high priority. This whole mechanism is already on its way out.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Mounir Lamouri (:mounir) from comment #0)
> mozilla::SafeAutoJSContext has been introduced in bug 828472 and could be
> used instead of the AutoSafeJSContext defined in Workers code.

Thanks for the heads up! If bholley can get rid of JSContexts altogether I'd be happier, but I can look at this sometime.

Comment 4

[Boris Zbarsky [:bzbarsky]]

SafeAutoJSContext is not a thing anymore. AutoSafeJSContext is a thing (though not defined in worker code), but not used on workers.

Resolving fixed, I guess, since we no longer use the worker-specific AutoSafeJSContext.