Persist the user's language selection in the DB

RESOLVED FIXED in 2013-05-02

Status

Marketplace
Consumer Pages
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: andym, Assigned: ashort)

Tracking

2013-05-02
x86
Mac OS X
Points:
---

Details

(Whiteboard: p=)

(Reporter)

Description

5 years ago
I think it would be nice to send localized emails to the users. Especially a receipt for payment of an app. To localize the receipt, I would need to know the users language preference. We currently have location on the user object, but not language. Could we persist the language as set on the user settings page?

Reviewer tools and other places could benefit from this too.
(Reporter)

Updated

5 years ago
Blocks: 833563
Assignee: nobody → charmston
Priority: -- → P3
Target Milestone: --- → 2013-02-14
Should this be prepopulated with the highest-weighted value of Accept-Language on the first visit with an empty value? (Perhaps through a piece of middleware, though I'm not sure how that would impact caching strategies.) Seems like a sane way to be immediately useful without the user needing to take explicit action.
(Reporter)

Comment 2

5 years ago
Saving it for a user on visit without having them to do anything should be fine, we'll only save it if its different. We set the locale for each request here:

https://github.com/mozilla/zamboni/blob/master/mkt/site/middleware.py#L157

That's the value we'd like to persist. Saving it from the settings page when its explicitly set would be good as well.
Assignee: charmston → scolville
Whiteboard: p=
Should we also persist the user's region?
(In reply to Chris Van Wiemeersch [:cvan] from comment #3)
> Should we also persist the user's region?

I thought that was already persisted by their choice.  Is that a cookie? If so, yeah, I think home region should be a part of the profile as well.
Target Milestone: 2013-02-14 → 2013-03-21
Target Milestone: 2013-03-21 → 2013-04-04
Target Milestone: 2013-04-04 → ---
Priority: P3 → P2
(Assignee)

Comment 5

4 years ago
https://github.com/mozilla/zamboni/commit/8e7fd0cabc1433eb71
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Target Milestone: --- → 2013-05-02
Assignee: scolville → ashort
Summary: Persist the users language selection in the DB → Persist the user's language selection in the DB
You need to log in before you can comment on or make changes to this bug.