833049 - Persist the user's language selection in the DB

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Andy McKay]

I think it would be nice to send localized emails to the users. Especially a receipt for payment of an app. To localize the receipt, I would need to know the users language preference. We currently have location on the user object, but not language. Could we persist the language as set on the user settings page?

Reviewer tools and other places could benefit from this too.

Comment 1

[Chuck Harmston [:chuck]]

Should this be prepopulated with the highest-weighted value of Accept-Language on the first visit with an empty value? (Perhaps through a piece of middleware, though I'm not sure how that would impact caching strategies.) Seems like a sane way to be immediately useful without the user needing to take explicit action.

Comment 2

[Andy McKay]

Saving it for a user on visit without having them to do anything should be fine, we'll only save it if its different. We set the locale for each request here:

https://github.com/mozilla/zamboni/blob/master/mkt/site/middleware.py#L157

That's the value we'd like to persist. Saving it from the settings page when its explicitly set would be good as well.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Should we also persist the user's region?

Comment 4

[Wil Clouser [:clouserw]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #3)
> Should we also persist the user's region?

I thought that was already persisted by their choice.  Is that a cookie? If so, yeah, I think home region should be a part of the profile as well.

Comment 5

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/8e7fd0cabc1433eb71